From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NFnwa-00041N-8h for qemu-devel@nongnu.org; Wed, 02 Dec 2009 07:04:28 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NFnwV-0003w9-Bu for qemu-devel@nongnu.org; Wed, 02 Dec 2009 07:04:27 -0500 Received: from [199.232.76.173] (port=48635 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NFnwV-0003vw-5y for qemu-devel@nongnu.org; Wed, 02 Dec 2009 07:04:23 -0500 Received: from david.siemens.de ([192.35.17.14]:18087) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NFnwU-00046F-Ko for qemu-devel@nongnu.org; Wed, 02 Dec 2009 07:04:22 -0500 Message-ID: <4B1657C0.20104@siemens.com> Date: Wed, 02 Dec 2009 13:04:16 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <1259671897-22232-1-git-send-email-glommer@redhat.com> <20091202105927.GB9537@redhat.com> In-Reply-To: <20091202105927.GB9537@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v2 0/11] List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gleb Natapov Cc: qemu-devel@nongnu.org, Glauber Costa , avi@redhat.com, agraf@suse.de, aliguori@us.ibm.com Gleb Natapov wrote: > On Tue, Dec 01, 2009 at 10:51:26AM -0200, Glauber Costa wrote: >> This is a repost of the -smp series. Note that it depends on irqchip-in-kernel, >> that is already in staging. Also, you'll have to enable the io-thread, for the time >> being. >> >> >From the last version, main change is that I am not calling queue_work automatically >> from vcpu ioctls. queue_work is only used currently for the gdb stub. >> >> All other uses were by-passed by the new qemu_register_vcpu_reset(), since most >> of it uses (all racy) came from the reset handlers. >> > Looks good to me except one thing. I don't see how you are addressing > the problem fixed by commit b8a7857071b477b28d3055e33ff0298fc91f329a > in qemu-kvm. The problem is that mp_state can change in kernel between > call to kvm_cpu_synchronize_state() and vcpu re-entry. In this case old > mp_state will overwrite new one. + nmi_pending + sipi_vector These things need to be fixed at kernel level as discussed recently: Asynchronous changes done by in-kernel subsystems need to be queued and replayed with a higher priority than user space changes. User space need to stop the vm if it does not want to be overruled. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux