From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NFo2T-00073k-6H
	for qemu-devel@nongnu.org; Wed, 02 Dec 2009 07:10:33 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NFo2N-0006zw-VG
	for qemu-devel@nongnu.org; Wed, 02 Dec 2009 07:10:32 -0500
Received: from [199.232.76.173] (port=44047 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NFo2M-0006z5-OT
	for qemu-devel@nongnu.org; Wed, 02 Dec 2009 07:10:26 -0500
Received: from thoth.sbs.de ([192.35.17.2]:22509)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <jan.kiszka@siemens.com>) id 1NFo2M-0004ZF-6U
	for qemu-devel@nongnu.org; Wed, 02 Dec 2009 07:10:26 -0500
Message-ID: <4B16592E.5030201@siemens.com>
Date: Wed, 02 Dec 2009 13:10:22 +0100
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <1259671897-22232-1-git-send-email-glommer@redhat.com>	<1259671897-22232-2-git-send-email-glommer@redhat.com>	<1259671897-22232-3-git-send-email-glommer@redhat.com>	<1259671897-22232-4-git-send-email-glommer@redhat.com>	<1259671897-22232-5-git-send-email-glommer@redhat.com>	<1259671897-22232-6-git-send-email-glommer@redhat.com>	<20091202104826.GA9537@redhat.com>
	<5d6222a80912020322s49e45015ga7b012ddd066c93b@mail.gmail.com>
In-Reply-To: <5d6222a80912020322s49e45015ga7b012ddd066c93b@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v2 05/11] tell kernel about all registers
 instead of just mp_state
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Glauber Costa <glommer@gmail.com>
Cc: aliguori@us.ibm.com, Gleb Natapov <gleb@redhat.com>, Glauber Costa <glommer@redhat.com>, agraf@suse.de, qemu-devel@nongnu.org, avi@redhat.com

Glauber Costa wrote:
>>> +{
>>> +    if (kvm_enabled()) {
>> Is this ever called or intended to be called when kvm is disabled?
>>
>>> +        kvm_cpu_flush_state(env);
>>> +    }
> 
> I don't think so. But this is here for consistency with its synchronize brother.

Ack. As soon as someone starts to use this generic service outside code
that is only built under CONFIG_KVM or called when kvm is enabled,
things will break.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux