From: Jie Zhang <jie.zhang@analog.com>
To: David Howells <dhowells@redhat.com>
Cc: Mike Frysinger <vapier@gentoo.org>,
uclinux-dev@uclinux.org, David McCullough <davidm@snapgear.com>,
Greg Ungerer <gerg@uclinux.org>, Paul Mundt <lethal@linux-sh.org>,
linux-kernel@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org
Subject: Re: [PATCH] NOMMU: use copy_*_user_page() in access_process_vm()
Date: Wed, 2 Dec 2009 23:07:37 +0800 [thread overview]
Message-ID: <4B1682B9.406@analog.com> (raw)
In-Reply-To: <16399.1259765124@redhat.com>
On 12/02/2009 10:45 PM, David Howells wrote:
> Mike Frysinger<vapier@gentoo.org> wrote:
>
>> The mmu code uses the copy_*_user_page() variants in access_process_vm()
>> rather than copy_*_user() as the former includes an icache flush. This is
>> important when doing things like setting software breakpoints with gdb.
>> So switch the nommu code over to do the same.
>
> Note that we may only really want to do an icache flush if the target region
> is mapped executable somewhere. On the other hand, for debugging stuff on an
> embedded board, it probably doesn't matter.
>
It is not checked before icache flush even for MMU. This is a place we
can do some improvement. But it's not important for debugging.
Jie
next prev parent reply other threads:[~2009-12-02 15:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-25 5:55 [PATCH] NOMMU: use copy_*_user_page() in access_process_vm() Mike Frysinger
2009-11-25 6:16 ` [uClinux-dev] " Jamie Lokier
2009-11-25 6:27 ` Jie Zhang
2009-11-25 6:51 ` Paul Mundt
2009-11-25 11:49 ` Jamie Lokier
2009-11-25 14:14 ` Jie Zhang
2009-11-25 18:39 ` Mike Frysinger
2009-11-25 6:19 ` David McCullough
2009-11-25 23:22 ` Greg Ungerer
2009-12-02 14:36 ` David Howells
2009-12-02 15:00 ` Jie Zhang
2009-12-02 14:45 ` David Howells
2009-12-02 15:07 ` Jie Zhang [this message]
2009-12-08 10:57 ` David Howells
2009-12-08 13:37 ` Jie Zhang
2009-12-08 14:19 ` David Howells
2009-12-08 14:30 ` Jie Zhang
2009-12-09 0:27 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B1682B9.406@analog.com \
--to=jie.zhang@analog.com \
--cc=davidm@snapgear.com \
--cc=dhowells@redhat.com \
--cc=gerg@uclinux.org \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=uclinux-dev@uclinux.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.