From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: [PATCH 0 of 3] Remus: control tool
Date: Wed, 02 Dec 2009 10:34:06 -0800
Message-ID: <4B16B31E.800@goop.org>
References: <C73C6199.35BA%keir.fraser@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <C73C6199.35BA%keir.fraser@eu.citrix.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: "andy@cs.ubc.ca" <andy@cs.ubc.ca>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, "konrad.wilk@oracle.com" <konrad.wilk@oracle.com>
List-Id: xen-devel@lists.xenproject.org

On 12/02/09 10:25, Keir Fraser wrote:
> From the tools p.o.v. the restore has finished when it kicks off execution
> of the guest. It's not that hard to handle this in the guest; you just need
> to do it. ;-)

Well, I think that just happens at the moment; the suspend is happening
from the xenstore watch thread, so there's no way it will even notice a
subsequent attempt until the suspend/resume cycle is done.

When we start triggering suspends from event channels, I'd suggest
something along the lines of wrapping the whole thing in a big fat
suspend mutex, and running the suspend from a workqueue triggered from
the interrupt or watch handler.  And then deal with all the edge cases.

    J