From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Fitzhardinge Subject: Re: [PATCH] xen: reduce severity of message about using v1 grant tables. Date: Wed, 02 Dec 2009 11:33:23 -0800 Message-ID: <4B16C103.9070105@goop.org> References: <1259782098-32180-1-git-send-email-Ian.Campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1259782098-32180-1-git-send-email-Ian.Campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Campbell Cc: Steven Smith , xen-devel@lists.xensource.com, Ian Campbell List-Id: xen-devel@lists.xenproject.org On 12/02/09 11:28, Ian Campbell wrote: > From: Ian Campbell > > It's hardly the end of the world... > > Signed-off-by: Ian Campbell > Cc: Jeremy Fitzhardinge > Cc: Steven Smith > --- > drivers/xen/grant-table.c | 19 ++++++++++--------- > 1 files changed, 10 insertions(+), 9 deletions(-) > > diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c > index 2240adf..85ce951 100644 > --- a/drivers/xen/grant-table.c > +++ b/drivers/xen/grant-table.c > @@ -699,21 +699,22 @@ static void gnttab_request_version(void) > > gsv.version = 2; > rc = HYPERVISOR_grant_table_op(GNTTABOP_set_version, &gsv, 1); > - if (rc == 0) { > + if (rc == 0) > grant_table_version = 2; > - printk(KERN_NOTICE "Using V2 grant tables.\n"); > - } else { > + else { > if (grant_table_version == 2) { > - /* If we've already used version 2 features, > - but then suddenly discover that they're not > - available (e.g. migrating to an older > - version of Xen), almost unbounded badness > - can happen. */ > + /* > + * If we've already used version 2 features, > + * but then suddenly discover that they're not > + * available (e.g. migrating to an older > + * version of Xen), almost unbounded badness > + * can happen. > + */ > panic("we need grant tables version 2, but only version 1 is available"); > Does it really need to be a panic? Can't we just start failing all future operations? Seems bad to take out the whole machine if we can just get away with crippling one device (especially if it can be recovered by downing it and re-upping a new one with nc1 and/or gt1). J