From: Michael Breuer <mbreuer@majjas.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Bug (minor): microcode_intel.c applies updates to hyperthreaded cores
Date: Wed, 02 Dec 2009 23:34:40 -0500 [thread overview]
Message-ID: <4B173FE0.7030302@majjas.com> (raw)
In-Reply-To: <20091202202012.0c7b6768@infradead.org>
Fair point - guess it's a different bug. Looks like the mechanism sets
up the requests first for all cpus, then loads them. apply_microcode
doesn't recheck.
CPU is a core i7 920; ht enabled. cpuinfo shows 4 cores; 8 cpus, as
expected.
From my log:
Dec 2 16:53:47 mail kernel: microcode: CPU0 sig=0x106a5, pf=0x2,
revision=0xf
Dec 2 16:53:47 mail kernel: platform microcode: firmware: requesting
intel-ucode/06-1a-05
Dec 2 16:53:47 mail kernel: microcode: CPU1 sig=0x106a5, pf=0x2,
revision=0xf
Dec 2 16:53:47 mail kernel: platform microcode: firmware: requesting
intel-ucode/06-1a-05
Dec 2 16:53:47 mail kernel: microcode: CPU2 sig=0x106a5, pf=0x2,
revision=0xf
Dec 2 16:53:47 mail kernel: platform microcode: firmware: requesting
intel-ucode/06-1a-05
Dec 2 16:53:47 mail kernel: microcode: CPU3 sig=0x106a5, pf=0x2,
revision=0xf
Dec 2 16:53:47 mail kernel: platform microcode: firmware: requesting
intel-ucode/06-1a-05
Dec 2 16:53:47 mail kernel: microcode: CPU4 sig=0x106a5, pf=0x2,
revision=0xf
Dec 2 16:53:47 mail kernel: platform microcode: firmware: requesting
intel-ucode/06-1a-05
Dec 2 16:53:47 mail kernel: microcode: CPU5 sig=0x106a5, pf=0x2,
revision=0xf
Dec 2 16:53:47 mail kernel: platform microcode: firmware: requesting
intel-ucode/06-1a-05
Dec 2 16:53:47 mail kernel: microcode: CPU6 sig=0x106a5, pf=0x2,
revision=0xf
Dec 2 16:53:47 mail kernel: platform microcode: firmware: requesting
intel-ucode/06-1a-05
Dec 2 16:53:47 mail kernel: microcode: CPU7 sig=0x106a5, pf=0x2,
revision=0xf
Dec 2 16:53:47 mail kernel: platform microcode: firmware: requesting
intel-ucode/06-1a-05
Dec 2 16:53:47 mail kernel: microcode: CPU0 updated to revision 0x11,
date = 2009-04-14
Dec 2 16:53:47 mail kernel: microcode: CPU1 updated to revision 0x11,
date = 2009-04-14
Dec 2 16:53:47 mail kernel: microcode: CPU2 updated to revision 0x11,
date = 2009-04-14
Dec 2 16:53:47 mail kernel: microcode: CPU3 updated to revision 0x11,
date = 2009-04-14
Dec 2 16:53:47 mail kernel: microcode: CPU4 updated to revision 0x11,
date = 2009-04-14
Dec 2 16:53:47 mail kernel: microcode: CPU5 updated to revision 0x11,
date = 2009-04-14
Dec 2 16:53:47 mail kernel: microcode: CPU6 updated to revision 0x11,
date = 2009-04-14
Dec 2 16:53:47 mail kernel: microcode: CPU7 updated to revision 0x11,
date = 2009-04-14
On 12/02/2009 11:20 PM, Arjan van de Ven wrote:
> On Wed, 02 Dec 2009 23:06:19 -0500
> Michael Breuer<mbreuer@majjas.com> wrote:
>
>
>> According to spec, microcode should only be applied to actual cores.
>> As things are currently structured, looks like the fix would be in
>> microcode_core.c. I don't think changing the loop to look for cores
>> vs. cpu's would affect anything adversely, but honestly am not
>> familiar enough with this code or other cpu types to be sure.
>>
>>
> isn't this
>
> for each (logical) cpu
> check microcode version of the cpu
> if too old, apply microcode
>
> the 2nd pair of a hyperthreading pair will never see the 'too old' case
> happen...
>
>
>
next prev parent reply other threads:[~2009-12-03 4:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-03 4:06 Bug (minor): microcode_intel.c applies updates to hyperthreaded cores Michael Breuer
2009-12-03 4:20 ` Arjan van de Ven
2009-12-03 4:34 ` Michael Breuer [this message]
2009-12-03 4:46 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B173FE0.7030302@majjas.com \
--to=mbreuer@majjas.com \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.