From: Jeff Garzik <jeff@garzik.org>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: Project Hail List <hail-devel@vger.kernel.org>
Subject: Re: [Patch 1/1] CLD: forgot FD_ZERO in test/large-object.c
Date: Thu, 03 Dec 2009 02:24:01 -0500 [thread overview]
Message-ID: <4B176791.7000108@garzik.org> (raw)
In-Reply-To: <20091202185306.57082694@redhat.com>
On 12/02/2009 08:53 PM, Pete Zaitcev wrote:
> Signed-Off-By: Pete Zaitcev<zaitcev@redhat.com>
> ---
> test/large-object.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/test/large-object.c b/test/large-object.c
> index f0884b8..fbed9b7 100644
> --- a/test/large-object.c
> +++ b/test/large-object.c
> @@ -28,6 +28,7 @@ static bool send_buf(struct st_client *stc, int sfd, void *buf, size_t buf_len)
> while (buf_len) {
> FD_ZERO(&wset);
> FD_SET(sfd,&wset);
> + FD_ZERO(&rset);
> FD_SET(sfd,&rset);
> rc = select(sfd + 1,&rset,&wset, NULL, NULL);
> OK(rc>= 0);
applied to chunkd ($subject indicated cld)
This is one of the many reasons why I prefer poll(2). One record per
poll entry, which is quite convenient for small numbers of fd's.
Jeff
prev parent reply other threads:[~2009-12-03 7:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-03 1:53 [Patch 1/1] CLD: forgot FD_ZERO in test/large-object.c Pete Zaitcev
2009-12-03 7:24 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B176791.7000108@garzik.org \
--to=jeff@garzik.org \
--cc=hail-devel@vger.kernel.org \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.