From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeff Garzik <jeff@garzik.org>
Subject: Re: [Patch 1/1] CLD: forgot FD_ZERO in test/large-object.c
Date: Thu, 03 Dec 2009 02:24:01 -0500
Message-ID: <4B176791.7000108@garzik.org>
References: <20091202185306.57082694@redhat.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Return-path: <hail-devel-owner@vger.kernel.org>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:received:received:sender:message-id:date:from
         :user-agent:mime-version:to:cc:subject:references:in-reply-to
         :content-type:content-transfer-encoding;
        bh=Y4iBKGwe9yPan5rIcD9joTaysD1KefeSHD9wv8a4z+A=;
        b=ebvKxoBW9z4z6h8k+wXN86ffcvAGwV3BMgQX7rvrGJTccO46IPa+HHB9rZL3d7IcVt
         A+76T4De4J6M+M2x/oVryyl6o6qA7LsxqPjzBmoMkfby7u0qUwwCIOJGMPZdg/q0JFFt
         UL+mrhMX4N6LRs8hOHlu0C+Kgmk7MIpRkjbHI=
In-Reply-To: <20091202185306.57082694@redhat.com>
Sender: hail-devel-owner@vger.kernel.org
List-ID: <hail-devel.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"; format="flowed"
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: Project Hail List <hail-devel@vger.kernel.org>

On 12/02/2009 08:53 PM, Pete Zaitcev wrote:
> Signed-Off-By: Pete Zaitcev<zaitcev@redhat.com>
> ---
>   test/large-object.c |    1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/test/large-object.c b/test/large-object.c
> index f0884b8..fbed9b7 100644
> --- a/test/large-object.c
> +++ b/test/large-object.c
> @@ -28,6 +28,7 @@ static bool send_buf(struct st_client *stc, int sfd, void *buf, size_t buf_len)
>   	while (buf_len) {
>   		FD_ZERO(&wset);
>   		FD_SET(sfd,&wset);
> +		FD_ZERO(&rset);
>   		FD_SET(sfd,&rset);
>   		rc = select(sfd + 1,&rset,&wset, NULL, NULL);
>   		OK(rc>= 0);

applied to chunkd ($subject indicated cld)

This is one of the many reasons why I prefer poll(2).  One record per 
poll entry, which is quite convenient for small numbers of fd's.

	Jeff