From: Cong Wang <amwang@redhat.com>
To: James Morris <jmorris@namei.org>
Cc: Joe Perches <joe@perches.com>,
linux-kernel@vger.kernel.org, Eric Paris <eparis@parisplace.org>,
linux-security-module@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [Patch] selinux: remove an unreachable line
Date: Thu, 03 Dec 2009 16:38:03 +0800 [thread overview]
Message-ID: <4B1778EB.3070605@redhat.com> (raw)
In-Reply-To: <alpine.LRH.2.00.0912012131440.27592@tundra.namei.org>
James Morris wrote:
> On Tue, 1 Dec 2009, Cong Wang wrote:
>
>>>> default:
>>>> return -EINVAL;
>>>> }
>>>> - return -EINVAL;
>>>> }
>>> I think it's better to remove the default case.
>>>
>> This is totally a personal taste, I think.
>> Either is OK. James, any comments?
>
> Leave the default: there but with a comment /* fall through */
> instead of the return.
>
Ok, will do, thanks.
next prev parent reply other threads:[~2009-12-03 8:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-01 7:41 [Patch] selinux: remove an unreachable line Amerigo Wang
2009-12-01 7:45 ` Joe Perches
2009-12-01 8:31 ` Cong Wang
2009-12-01 10:33 ` James Morris
2009-12-03 8:38 ` Cong Wang [this message]
2009-12-02 12:35 ` Dan Carpenter
2009-12-03 8:39 ` Cong Wang
2009-12-03 19:38 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B1778EB.3070605@redhat.com \
--to=amwang@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=eparis@parisplace.org \
--cc=jmorris@namei.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.