From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH]: Fix sparc64 build...
Date: Thu, 03 Dec 2009 12:26:05 +0100 [thread overview]
Message-ID: <4B17A04D.20505@gmail.com> (raw)
In-Reply-To: <20091203.021729.127643119.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 3974 bytes --]
Hello, nice to see you again.
David Miller wrote:
> So I finally am about to have enough time to start looking into
> sparc64 support again.
>
>
> And, surprise! The trunk doesn't even build. :-)
>
Committed. BTW in experimental we merged sparc64's and i386's
grub-install. Do you think it would make sense to merge some other tools
as well?
> 2009-12-03 David S. Miller <davem@sunset.davemloft.net>
>
> * conf/sparc64-ieee1275.rmk (grub_mkimage_SOURCES,
> grub_setup_SOURCES, grub_ofpathname_SOURCES): Add gnulib/progname.c
> * util/sparc64/ieee1275/grub-mkimage.c: Include <grub/i18n.h> and
> "progname.h"
> * util/sparc64/ieee1275/grub-ofpathname.c: Likewise.
> * util/sparc64/ieee1275/grub-setup.c: Likewise.
> (usage): Add missing comma in printf.
>
> === modified file 'conf/sparc64-ieee1275.rmk'
> --- conf/sparc64-ieee1275.rmk 2009-11-26 00:45:53 +0000
> +++ conf/sparc64-ieee1275.rmk 2009-12-03 10:06:44 +0000
> @@ -63,7 +63,7 @@
>
> # For grub-mkimage.
> grub_mkimage_SOURCES = util/sparc64/ieee1275/grub-mkimage.c util/misc.c \
> - util/resolve.c
> + util/resolve.c gnulib/progname.c
>
> # For grub-setup.
> util/sparc64/ieee1275/grub-setup.c_DEPENDENCIES = grub_setup_init.h
> @@ -82,12 +82,12 @@
> partmap/sun.c partmap/acorn.c \
> \
> disk/raid.c disk/mdraid_linux.c disk/lvm.c \
> - util/raid.c util/lvm.c \
> + util/raid.c util/lvm.c gnulib/progname.c \
> grub_setup_init.c
>
> # For grub-ofpathname.
> grub_ofpathname_SOURCES = util/sparc64/ieee1275/grub-ofpathname.c \
> - util/ieee1275/ofpath.c util/misc.c
> + util/ieee1275/ofpath.c util/misc.c gnulib/progname.c
>
> # Scripts.
> sbin_SCRIPTS = grub-install
>
> === modified file 'util/sparc64/ieee1275/grub-mkimage.c'
> --- util/sparc64/ieee1275/grub-mkimage.c 2009-11-25 23:10:02 +0000
> +++ util/sparc64/ieee1275/grub-mkimage.c 2009-12-03 09:59:51 +0000
> @@ -21,6 +21,7 @@
> #include <grub/machine/boot.h>
> #include <grub/machine/kernel.h>
> #include <grub/kernel.h>
> +#include <grub/i18n.h>
> #include <grub/disk.h>
> #include <grub/util/misc.h>
> #include <grub/util/resolve.h>
> @@ -34,6 +35,8 @@
> #define _GNU_SOURCE 1
> #include <getopt.h>
>
> +#include "progname.h"
> +
> static void
> compress_kernel (char *kernel_img, size_t kernel_size,
> char **core_img, size_t *core_size)
>
> === modified file 'util/sparc64/ieee1275/grub-ofpathname.c'
> --- util/sparc64/ieee1275/grub-ofpathname.c 2009-11-25 23:10:02 +0000
> +++ util/sparc64/ieee1275/grub-ofpathname.c 2009-12-03 10:06:14 +0000
> @@ -20,6 +20,10 @@
> #include <grub/util/misc.h>
> #include <grub/util/ofpath.h>
>
> +#include <grub/i18n.h>
> +
> +#include "progname.h"
> +
> int main(int argc, char **argv)
> {
> char *of_path;
>
> === modified file 'util/sparc64/ieee1275/grub-setup.c'
> --- util/sparc64/ieee1275/grub-setup.c 2009-11-25 23:10:02 +0000
> +++ util/sparc64/ieee1275/grub-setup.c 2009-12-03 10:04:44 +0000
> @@ -21,6 +21,7 @@
> #include <grub/types.h>
> #include <grub/util/misc.h>
> #include <grub/device.h>
> +#include <grub/i18n.h>
> #include <grub/disk.h>
> #include <grub/file.h>
> #include <grub/fs.h>
> @@ -49,6 +50,8 @@
> #define _GNU_SOURCE 1
> #include <getopt.h>
>
> +#include "progname.h"
> +
> /* This program fills in various fields inside of the 'boot' and 'core'
> * image files.
> *
> @@ -419,7 +422,7 @@
> -v, --verbose print verbose messages\n\
> \n\
> Report bugs to <%s>.\n\
> -", program_name
> +", program_name,
> DEFAULT_BOOT_FILE, DEFAULT_CORE_FILE, DEFAULT_DIRECTORY,
> DEFAULT_DEVICE_MAP, PACKAGE_BUGREPORT);
>
>
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
>
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 293 bytes --]
next prev parent reply other threads:[~2009-12-03 11:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-03 10:17 [PATCH]: Fix sparc64 build David Miller
2009-12-03 11:26 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2009-12-03 19:02 ` David Miller
2009-12-03 20:22 ` Vladimir 'φ-coder/phcoder' Serbinenko
2009-12-03 20:59 ` David Miller
2009-12-03 21:56 ` Vladimir 'φ-coder/phcoder' Serbinenko
2009-12-03 22:04 ` David Miller
2009-12-04 20:54 ` Robert Millan
2009-12-03 21:03 ` David Miller
2009-12-04 20:58 ` Robert Millan
2009-12-04 21:34 ` David Miller
2009-12-06 9:12 ` Felix Zielcke
2009-12-04 20:52 ` Robert Millan
2009-12-04 20:50 ` Robert Millan
-- strict thread matches above, loose matches on Subject: below --
2009-05-04 22:55 David Miller
2009-03-26 23:44 David Miller
2009-03-27 0:16 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B17A04D.20505@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.