From: Joonyoung Shim <jy0922.shim@samsung.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Samu Onkalo <samu.p.onkalo@nokia.com>,
dmitry.torokhov@gmail.com, linux-input@vger.kernel.org
Subject: Re: [PATCH] input: enable / disable methods with sysfs entry
Date: Thu, 03 Dec 2009 20:42:38 +0900 [thread overview]
Message-ID: <4B17A42E.3000805@samsung.com> (raw)
In-Reply-To: <20091203110834.GF13165@rakim.wolfsonmicro.main>
On 12/3/2009 8:08 PM, Mark Brown wrote:
> On Thu, Dec 03, 2009 at 12:58:19PM +0200, Samu Onkalo wrote:
>> Add optional enable and disable methods to input system.
>> Add sysfs entry for enabling and disabling input device.
>
>> When registering a device to input system, device can provide
>> optional enable and disable methods. State is set to enabled by default.
>> Opening / closing the input device doesn't change the state.
>> If the callback functions are not provided, sysfs entry returns
>> ENOSYS error code.
>
> I'm wondering if it might be nice to provide a default implementation
> which causes the input core to ignore the events generated by the device
> if the driver doesn't support being enabled or disabled? Obviously this
> wouldn't be of any benefit in preventing resume or providing power
> saving but it would give userspace the same effect which might be useful
> to it for UI purposes.
I think a default implementation of the input core for this is useful
ex. at gpio-keys driver.
next prev parent reply other threads:[~2009-12-03 11:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-03 10:58 [PATCH] input: Enable / disable methods Samu Onkalo
2009-12-03 10:58 ` [PATCH] input: enable / disable methods with sysfs entry Samu Onkalo
2009-12-03 10:58 ` [PATCH] input: twl4030_keypad enable / disable feature Samu Onkalo
2009-12-03 11:08 ` [PATCH] input: enable / disable methods with sysfs entry Mark Brown
2009-12-03 11:42 ` Joonyoung Shim [this message]
2009-12-03 15:20 ` Ferenc Wagner
2009-12-03 17:22 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B17A42E.3000805@samsung.com \
--to=jy0922.shim@samsung.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=samu.p.onkalo@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.