All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Glauber Costa <glommer@gmail.com>
Cc: Glauber Costa <glommer@redhat.com>,
	aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH 04/11] qemu_flush_work for remote vcpu execution
Date: Thu, 03 Dec 2009 14:40:04 +0200	[thread overview]
Message-ID: <4B17B1A4.8070209@redhat.com> (raw)
In-Reply-To: <5d6222a80912030437o3be79b67wf88d4c6b275aa526@mail.gmail.com>

On 12/03/2009 02:37 PM, Glauber Costa wrote:
>> "Because it fixes things".
>>
>> Please elaborate.
>>
>>      
> gdbstub is called from the i/o thread , and call vcpu ioctls. So it
> has to use the on_vcpu
> mechanism to guarantee its execution in the right thread.
>
> What I meant is that currently, gdbstub is the only user of it, at
> least in qemu.git
>    

In this case, the patch is unnecessary for smp.  Please submit it 
separately from this patchset, with a proper changelog.


-- 
error compiling committee.c: too many arguments to function

  reply	other threads:[~2009-12-03 12:40 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-02 13:48 [Qemu-devel] [PATCH 00/11] SMP support in qemu.git Glauber Costa
2009-12-02 13:48 ` [Qemu-devel] [PATCH 01/11] Don't mess with halted state Glauber Costa
2009-12-02 13:48   ` [Qemu-devel] [PATCH 02/11] store thread-specific env information Glauber Costa
2009-12-02 13:48     ` [Qemu-devel] [PATCH 03/11] update halted state on mp_state sync Glauber Costa
2009-12-02 13:48       ` [Qemu-devel] [PATCH 04/11] qemu_flush_work for remote vcpu execution Glauber Costa
2009-12-02 13:48         ` [Qemu-devel] [PATCH 05/11] tell kernel about all registers instead of just mp_state Glauber Costa
2009-12-02 13:48           ` [Qemu-devel] [PATCH 06/11] flush state in migration post_load Glauber Costa
2009-12-02 13:48             ` [Qemu-devel] [PATCH 07/11] Don't call kvm cpu reset on initialization Glauber Costa
2009-12-02 13:48               ` [Qemu-devel] [PATCH 08/11] use cpu_kick instead of direct signalling Glauber Costa
2009-12-02 13:48                 ` [Qemu-devel] [PATCH 09/11] Use per-cpu reset handlers Glauber Costa
2009-12-02 13:48                   ` [Qemu-devel] [PATCH 10/11] Use __thread where available Glauber Costa
2009-12-02 13:48                     ` [Qemu-devel] [PATCH 11/11] remove smp restriction from kvm Glauber Costa
2009-12-03 12:23                       ` [Qemu-devel] " Avi Kivity
2009-12-03 12:36                         ` Glauber Costa
2009-12-03 12:37                           ` Avi Kivity
2009-12-03 12:39                             ` Glauber Costa
2009-12-03 12:40                               ` Avi Kivity
2009-12-03 12:20         ` [Qemu-devel] Re: [PATCH 04/11] qemu_flush_work for remote vcpu execution Avi Kivity
2009-12-03 12:33           ` Glauber Costa
2009-12-03 12:35             ` Avi Kivity
2009-12-03 12:37               ` Glauber Costa
2009-12-03 12:40                 ` Avi Kivity [this message]
2009-12-03 14:29         ` Paolo Bonzini
2009-12-03 15:02           ` Glauber Costa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B17B1A4.8070209@redhat.com \
    --to=avi@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=glommer@gmail.com \
    --cc=glommer@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.