From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NGHe5-0005yg-SY
	for qemu-devel@nongnu.org; Thu, 03 Dec 2009 14:47:21 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NGHe0-0005wM-LY
	for qemu-devel@nongnu.org; Thu, 03 Dec 2009 14:47:20 -0500
Received: from [199.232.76.173] (port=59247 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NGHe0-0005wH-CQ
	for qemu-devel@nongnu.org; Thu, 03 Dec 2009 14:47:16 -0500
Received: from mail-qy0-f194.google.com ([209.85.221.194]:64886)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NGHdz-0003r5-Tm
	for qemu-devel@nongnu.org; Thu, 03 Dec 2009 14:47:16 -0500
Received: by qyk32 with SMTP id 32so708430qyk.4
	for <qemu-devel@nongnu.org>; Thu, 03 Dec 2009 11:47:15 -0800 (PST)
Message-ID: <4B1815C0.7030007@codemonkey.ws>
Date: Thu, 03 Dec 2009 13:47:12 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [STAGING]: Block migration segfaults
References: <20091203162121.67d9c120@doriath>	<4B18051F.4040207@siemens.com>	<20091203165907.2498d13c@doriath>
	<4B180D1B.6050307@web.de>
In-Reply-To: <4B180D1B.6050307@web.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "lirans@il.ibm.com" <lirans@il.ibm.com>, Luiz Capitulino <lcapitulino@redhat.com>

Jan Kiszka wrote:
> Luiz Capitulino wrote:
>   
>> On Thu, 03 Dec 2009 19:36:15 +0100
>> Jan Kiszka <jan.kiszka@siemens.com> wrote:
>>
>>     
>>> Luiz Capitulino wrote:
>>>       
>>>>  Hi there,
>>>>
>>>>  Got this while testing block migration in staging:
>>>>
>>>> """
>>>> Program terminated with signal 11, Segmentation fault.
>>>> #0  0x0000000000410cf9 in monitor_vprintf (mon=0x0, fmt=0x5ae5e7 "Start full migration for %s\n",
>>>> ap=0x7fff1f830a40) at /home/lcapitulino/src/aliguori-queue/monitor.c:192
>>>> 192         if (mon->mc && !mon->mc->print_enabled) {
>>>> """
>>>>
>>>>  The problem here is that init_blk_migration() calls monitor_printf() with
>>>> a NULL 'mon' and the backtrace shows that this is true for the entire call
>>>> chain.
>>>>         
>>> What is the backtrace? And how did you start the migration?
>>>       
>>  Started the source VM with:
>>
>> # qemu -hda disks/fedora-11-kratos-i386.img -enable-kvm -snapshot \
>>        -balloon virtio -m 1G -S
>>
>>  and the destination one with:
>>
>> # qemu -hda disks/fedora-11-kratos-i386.img -enable-kvm -snapshot \
>>        -balloon virtio -m 1G -S -incoming tcp:0:4444
>>
>>  Migration command issued:
>>
>> (QEMU) migrate -d -b tcp:0:4444
>>
>>     
>
> Ah, forgot '-d'! Yes, that was precisely the use case for suppressing
> monitor output I was talking about. This depends on the monitor services
> catching NULL properly, so please push the corresponding patch.
>   

Man I really hate detach.  Okay, I agree re: a patch.

Regards,

Anthony Liguori