From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Fitzhardinge Subject: Re: [PATCH 3/3] xen: rename pciback module to xen-pciback. Date: Thu, 03 Dec 2009 14:18:35 -0800 Message-ID: <4B18393B.4050700@goop.org> References: <1259877380-32275-1-git-send-email-ian.campbell@citrix.com> <1259877380-32275-4-git-send-email-ian.campbell@citrix.com> <20091203220237.GA21885@phenom.dumpdata.com> <1259878468.31045.139.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1259878468.31045.139.camel@localhost.localdomain> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Campbell Cc: "xen-devel@lists.xensource.com" , Konrad Rzeszutek Wilk List-Id: xen-devel@lists.xenproject.org On 12/03/09 14:14, Ian Campbell wrote: > Ah, it never even occurred to me that such a thing would be necessary. > > I think (but I should check) that the sysfs name will remain pciback > since it comes from the .name in struct xenbus_driver. I'm not sure if > it is confusing or not to have the module name be different to the > driver name nor how common it is. > The driver name is a bit of an ABI for hotplug, etc, anyway, so having the Xen tools depend on that name isn't very odd. And while it is best if the module matches the driver name, it's not uncommon for it to mismatch - and we've been doing it for ages anyway (xen_netfront is called "vif" and aliased "xen:vif" and "xennet"). J