From: Liang Zhen <Zhen.Liang@Sun.COM>
To: lustre-devel@lists.lustre.org
Subject: [Lustre-devel] client-side reply handling
Date: Fri, 04 Dec 2009 11:30:13 +0800 [thread overview]
Message-ID: <4B188245.7030503@sun.com> (raw)
In-Reply-To: <4EDD2ECF-5FC1-4410-9F70-09D07EF1C4FF@sun.com>
Robert Read wrote:
>>
>>
>>> b) The request is re-sent and the same reply matchbits are used,
>>> which is what I think happens currently for non-bulk reqs.
>>>
>> In theory, the reply to the re-sent request should be identical due
>> to reply reconstruction, so it shouldn't matter if it happens to
>> overwrite the same buffer.
>>
>
> That's fine as long as the buffer is unlinked from the net before it gets swabbed, but hopefully that's the case already.
>
I'm afraid it's not the case in ptlrpc_check_set(), we begin to swab
reply when the request is marked as replied and unregister(unlink) reply
buffer after that, it's the reason Eric brought the topic...
Liang
> robert
>
> _______________________________________________
> Lustre-devel mailing list
> Lustre-devel at lists.lustre.org
> http://lists.lustre.org/mailman/listinfo/lustre-devel
>
next prev parent reply other threads:[~2009-12-04 3:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-03 15:00 [Lustre-devel] client-side reply handling Eric Barton
2009-12-03 21:17 ` Andreas Dilger
2009-12-03 22:23 ` Robert Read
2009-12-04 3:14 ` Isaac Huang
2009-12-04 3:30 ` Liang Zhen [this message]
2009-12-04 11:07 ` Eric Barton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B188245.7030503@sun.com \
--to=zhen.liang@sun.com \
--cc=lustre-devel@lists.lustre.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.