From: Line Holen <Line.Holen-UdXhSnd/wVw@public.gmane.org>
To: sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH] opensm/osm_vendor_ibumad.c: Move error info into single message
Date: Fri, 04 Dec 2009 10:41:50 +0100 [thread overview]
Message-ID: <4B18D95E.1090007@Sun.COM> (raw)
The information in ERR 5409 is moved into 5410/5411 to reduce
number of messages
Signed-off-by: Line Holen <Line.Holen-xsfywfwIY+M@public.gmane.org>
---
diff --git a/opensm/libvendor/osm_vendor_ibumad.c b/opensm/libvendor/osm_vendor_ibumad.c
index 8f9bbf5..b4319cd 100644
--- a/opensm/libvendor/osm_vendor_ibumad.c
+++ b/opensm/libvendor/osm_vendor_ibumad.c
@@ -3,6 +3,7 @@
* Copyright (c) 2002-2005 Mellanox Technologies LTD. All rights reserved.
* Copyright (c) 1996-2003 Intel Corporation. All rights reserved.
* Copyright (c) 2009 HNR Consulting. All rights reserved.
+ * Copyright (c) 2009 Sun Microsystems, Inc. All rights reserved.
*
* This software is available to you under a choice of one of two
* licenses. You may choose to be licensed under the terms of the GNU
@@ -325,28 +326,30 @@ static void *umad_receiver(void *p_ptr)
/* if status != 0 then we are handling recv timeout on send */
if (umad_status(p_madw->vend_wrap.umad)) {
- OSM_LOG(p_vend->p_log, OSM_LOG_ERROR, "ERR 5409: "
- "send completed with error"
- " (method=0x%X attr=0x%X trans_id=0x%" PRIx64
- ") -- dropping\n",
- mad->method, cl_ntoh16(mad->attr_id),
- cl_ntoh64(mad->trans_id));
+
if (mad->mgmt_class != IB_MCLASS_SUBN_DIR) {
/* LID routed */
- OSM_LOG(p_vend->p_log, OSM_LOG_ERROR,
- "ERR 5410: class 0x%x LID %u\n",
- mad->mgmt_class,
+ OSM_LOG(p_vend->p_log, OSM_LOG_ERROR, "ERR 5410: "
+ "Send completed with error -- dropping\n"
+ "\t\t\tClass 0x%x, Method 0x%X, Attr 0x%X, "
+ "TID 0x%" PRIx64 ", LID %u\n",
+ mad->mgmt_class, mad->method,
+ cl_ntoh16(mad->attr_id),
+ cl_ntoh64(mad->trans_id),
cl_ntoh16(ib_mad_addr->lid));
} else {
ib_smp_t *smp;
/* Direct routed SMP */
smp = (ib_smp_t *) mad;
- OSM_LOG(p_vend->p_log, OSM_LOG_ERROR,
- "ERR 5411: DR SMP Hop Ptr: 0x%X\n",
- smp->hop_ptr);
+ OSM_LOG(p_vend->p_log, OSM_LOG_ERROR, "ERR 5411: "
+ "DR SMP Send completed with error -- dropping\n"
+ "\t\t\tMethod 0x%X, Attr 0x%X, TID 0x%" PRIx64
+ ", Hop Ptr: 0x%X\n",
+ mad->method, cl_ntoh16(mad->attr_id),
+ cl_ntoh64(mad->trans_id), smp->hop_ptr);
osm_dump_smp_dr_path(p_vend->p_log, smp,
- OSM_LOG_ERROR);
+ OSM_LOG_VERBOSE);
}
if (!(p_req_madw = get_madw(p_vend, &mad->trans_id))) {
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2009-12-04 9:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-04 9:41 Line Holen [this message]
[not found] ` <4B18D95E.1090007-UdXhSnd/wVw@public.gmane.org>
2009-12-13 14:16 ` [PATCH] opensm/osm_vendor_ibumad.c: Move error info into single message Sasha Khapyorsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B18D95E.1090007@Sun.COM \
--to=line.holen-udxhsnd/wvw@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.