* mips/*/time.h
@ 2009-12-04 15:58 Robert Millan
2009-12-04 16:24 ` mips/*/time.h Vladimir 'φ-coder/phcoder' Serbinenko
0 siblings, 1 reply; 3+ messages in thread
From: Robert Millan @ 2009-12-04 15:58 UTC (permalink / raw)
To: grub-devel
Hi,
In mips branch grub_cpu_idle() is provided by grub/mips/yeeloong/time.h
and grub/mips/qemu-mips/time.h, but there's no grub/mips/time.h.
This breaks mipsel-emu port, which lacks this definition. Why not merge
mips/yeeloong/time.h and mips/qemu-mips/time.h into mips/time.h ? Both
files are identical.
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: mips/*/time.h
2009-12-04 15:58 mips/*/time.h Robert Millan
@ 2009-12-04 16:24 ` Vladimir 'φ-coder/phcoder' Serbinenko
2009-12-04 21:01 ` mips/*/time.h Robert Millan
0 siblings, 1 reply; 3+ messages in thread
From: Vladimir 'φ-coder/phcoder' Serbinenko @ 2009-12-04 16:24 UTC (permalink / raw)
To: The development of GNU GRUB
[-- Attachment #1: Type: text/plain, Size: 601 bytes --]
Robert Millan wrote:
> Hi,
>
> In mips branch grub_cpu_idle() is provided by grub/mips/yeeloong/time.h
> and grub/mips/qemu-mips/time.h, but there's no grub/mips/time.h.
>
> This breaks mipsel-emu port, which lacks this definition. Why not merge
> mips/yeeloong/time.h and mips/qemu-mips/time.h into mips/time.h ? Both
> files are identical.
>
>
Both are stubs actually. Why does *-emu needs these files at all? *-emu
doesn't see this type of machine info. It should just use host function
for both cpu_idle and get_rtc
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 293 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: mips/*/time.h
2009-12-04 16:24 ` mips/*/time.h Vladimir 'φ-coder/phcoder' Serbinenko
@ 2009-12-04 21:01 ` Robert Millan
0 siblings, 0 replies; 3+ messages in thread
From: Robert Millan @ 2009-12-04 21:01 UTC (permalink / raw)
To: The development of GNU GRUB
On Fri, Dec 04, 2009 at 05:24:02PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> Robert Millan wrote:
> > Hi,
> >
> > In mips branch grub_cpu_idle() is provided by grub/mips/yeeloong/time.h
> > and grub/mips/qemu-mips/time.h, but there's no grub/mips/time.h.
> >
> > This breaks mipsel-emu port, which lacks this definition. Why not merge
> > mips/yeeloong/time.h and mips/qemu-mips/time.h into mips/time.h ? Both
> > files are identical.
> >
> >
> Both are stubs actually. Why does *-emu needs these files at all? *-emu
> doesn't see this type of machine info. It should just use host function
> for both cpu_idle and get_rtc
grub_cpu_idle is implemented as an inline stub, which resides in time.h.
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-12-04 21:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-04 15:58 mips/*/time.h Robert Millan
2009-12-04 16:24 ` mips/*/time.h Vladimir 'φ-coder/phcoder' Serbinenko
2009-12-04 21:01 ` mips/*/time.h Robert Millan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.