Re: [PATCH 1/1] lpfc: lpfc no longer discovers lun 255

[Michael Reed <mdr@sgi.com>]

Yeah.  I'm working on a patch for qla1280.c also.  Probably others
have been hit.  It would have been nice if the patch author had
fixed all the drivers instead of introducing this change and waiting
for people to discover their last lun is now missing.

James Smart wrote:
> Thanks Mike.   Wonder if that change broke other drivers too...
> 
> Acked-By:   James Smart <james.smart@emulex.com>
> 
> -- james s
> 
> Michael Reed wrote:
>> A change in lun scanning range in scsi_scan.c ( ">" becomes ">=") results
>> in lpfc no longer discovering lun 255 of my test configuration.  This
>> patch adjusts lpfc_attr.c to discover lun 255 again.
>>
>> scsi: host 3 channel 0 id 17 lun255 has a LUN larger than allowed by the host adapter
>>
>>
>> Signed-off-by: Michael Reed <mdr@sgi.com>
>>
>>
>> --- scsi-misc-2.6/drivers/scsi/lpfc/lpfc_attr.c	2009-12-01 16:18:40.000000000 -0600
>> +++ scsi-misc-2.6-modified/drivers/scsi/lpfc/lpfc_attr.c	2009-12-04 10:01:52.091503203 -0600
>> @@ -3099,10 +3099,10 @@ LPFC_VPORT_ATTR(discovery_threads, 32, 1
>>  
>>  /*
>>  # lpfc_max_luns: maximum allowed LUN.
>> -# Value range is [0,65535]. Default value is 255.
>> +# Value range is [0,65535]. Default value is 256, 1 greater than max lun number.
>>  # NOTE: The SCSI layer might probe all allowed LUN on some old targets.
>>  */
>> -LPFC_VPORT_ATTR_R(max_luns, 255, 0, 65535, "Maximum allowed LUN");
>> +LPFC_VPORT_ATTR_R(max_luns, 256, 0, 65535, "Maximum allowed LUN");
>>  
>>  /*
>>  # lpfc_poll_tmo: .Milliseconds driver will wait between polling FCP ring.
>>
>>   
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html