From: John Johansen <john.johansen@canonical.com>
To: David Howells <dhowells@redhat.com>
Cc: Eric Paris <eparis@redhat.com>,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org,
akpm@linux-foundation.org, gyang@blackfin.uclinux.org
Subject: Re: [PATCH] security: do not check mmap_min_addr on nommu systems
Date: Fri, 04 Dec 2009 14:44:27 -0800 [thread overview]
Message-ID: <4B1990CB.5090702@canonical.com> (raw)
In-Reply-To: <32275.1259923944@redhat.com>
David Howells wrote:
> Eric Paris <eparis@redhat.com> wrote:
>
>> +/* sec_flags for security_file_mmap */
>> +/* Only check the address portion */
>> +#define SECURITY_MMAP_ADDR_ONLY 0x01
>> +/* Do not do the address checks */
>> +#define SECURITY_MMAP_NOT_ADDR 0x02
>
> I'm still not happy with the names assigned to these constants.
>
> Can we call them:
>
> #define SECURITY_MMAP_ADDR_CHECK_ONLY 0x01
> #define SECURITY_MMAP_SKIP_ADDR_CHECK 0x02
>
> and then discard the comments?
I do like these suggested names a little better. Either way I am happy
with the patch.
next prev parent reply other threads:[~2009-12-04 22:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-03 19:43 [PATCH] security: do not check mmap_min_addr on nommu systems Eric Paris
2009-12-03 19:58 ` Andrew Morton
2009-12-04 20:01 ` Eric Paris
2009-12-04 10:52 ` David Howells
2009-12-04 21:55 ` David Howells
2009-12-04 22:44 ` John Johansen [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-12-05 3:26 Eric Paris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B1990CB.5090702@canonical.com \
--to=john.johansen@canonical.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=eparis@redhat.com \
--cc=gyang@blackfin.uclinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.