From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Andy Walls <awalls@radix.net>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
linux-media@vger.kernel.org
Subject: Re: Heads up, I'm adding IR stuff to cx23885 and cx25840
Date: Sun, 06 Dec 2009 01:27:37 -0200 [thread overview]
Message-ID: <4B1B24A9.2040304@redhat.com> (raw)
In-Reply-To: <1260068865.3105.50.camel@palomino.walls.org>
Andy Walls wrote:
> Mauro,
>
> I noticed you've added some changes to th v4l-dvb tree for IR.
>
> Just to let you know, I've added an NEC protocol implementation to
> cx23885-input.c. The two relevant changes are here:
>
> cx23885: Convert from struct card_ir to struct cx23885_ir_input for IR Rx
> http://linuxtv.org/hg/~awalls/cx23885-ir/rev/c51daeba32cb
>
> cx23885: Add NEC protocol decoding for IR Rx
> http://linuxtv.org/hg/~awalls/cx23885-ir/rev/6cba2fc1ea99
>
> I haven't kept track with all your changes so far, but just wanted to
> let you know these would be ready sometime before Christmas for
> hopefully the HVR-1800 and TeVii S470. Hopefully, the changes will also
> be brought up to date with your changes by then too.
By looking on your code, as you're calling:
ir_input_init(input_dev, &ir->ir, ir_type, ir_codes);
You'll already be using my new code. However, you'll need to add a call to ir_input_free(input_dev),
at the IR unregistering code, and on an error condition.
You should notice that you're not limited to use only 128 scancodes from 0 to 127, as the
previous versions of the ir-common allowed. The new version supports 32 bits for scancodes,
and use dynamic allocation to allow adding/removing codes from the table.
Cheers,
Mauro.
prev parent reply other threads:[~2009-12-06 3:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-06 3:07 Heads up, I'm adding IR stuff to cx23885 and cx25840 Andy Walls
2009-12-06 3:27 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B1B24A9.2040304@redhat.com \
--to=mchehab@redhat.com \
--cc=awalls@radix.net \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.