From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NHKMH-0007EX-QE
	for qemu-devel@nongnu.org; Sun, 06 Dec 2009 11:53:17 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NHKMH-0007DP-Ab
	for qemu-devel@nongnu.org; Sun, 06 Dec 2009 11:53:17 -0500
Received: from [199.232.76.173] (port=34936 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NHKMH-0007DL-7K
	for qemu-devel@nongnu.org; Sun, 06 Dec 2009 11:53:17 -0500
Received: from bhuna.collabora.co.uk ([93.93.128.226]:60571)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <ian.molton@collabora.co.uk>) id 1NHKMG-0004pO-QB
	for qemu-devel@nongnu.org; Sun, 06 Dec 2009 11:53:17 -0500
Message-ID: <4B1BE153.6070509@collabora.co.uk>
Date: Sun, 06 Dec 2009 16:52:35 +0000
From: Ian Molton <ian.molton@collabora.co.uk>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Permit zero-sized qemu_malloc() & friends
References: <m3skbwxgkp.fsf@crossbow.pond.sub.org>	<4B193DA5.6040507@codemonkey.ws>
	<4B1A9359.8080305@redhat.com>	<4B1A9811.8020108@codemonkey.ws>
	<m3vdgky0za.fsf@crossbow.pond.sub.org>
In-Reply-To: <m3vdgky0za.fsf@crossbow.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Paul Brook <paul@codesourcery.com>, qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>

Markus Armbruster wrote:

>     p = malloc(n * sizeof(struct foo);
>     if (n && !p)
>         exit_no_mem();
>     for (i = 0; i < n; i++)
>         compute_one(p, i);
> 
> With qemu_malloc(), the error handling moves into qemu_malloc():
> 
>     p = qemu_malloc(n * sizeof(struct foo);
>     for (i = 0; i < n; i++)
>         compute_one(p, i);

And you lose the ability to fail gracefully...