From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NHYtY-0005GV-Bc
	for qemu-devel@nongnu.org; Mon, 07 Dec 2009 03:24:36 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NHYtU-0005G3-0s
	for qemu-devel@nongnu.org; Mon, 07 Dec 2009 03:24:35 -0500
Received: from [199.232.76.173] (port=33043 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NHYtT-0005G0-QJ
	for qemu-devel@nongnu.org; Mon, 07 Dec 2009 03:24:31 -0500
Received: from fmmailgate02.web.de ([217.72.192.227]:49928)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <jan.kiszka@web.de>) id 1NHYtT-0003LZ-8M
	for qemu-devel@nongnu.org; Mon, 07 Dec 2009 03:24:31 -0500
Message-ID: <4B1CBBB9.1000807@web.de>
Date: Mon, 07 Dec 2009 09:24:25 +0100
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <4B1BC4EC.90704@web.de> <4B1CB903.9000900@redhat.com>
In-Reply-To: <4B1CB903.9000900@redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig0354BED6A3C3B00E99155D8A"
Sender: jan.kiszka@web.de
Subject: [Qemu-devel] Re: [PATCH] kvm: x86: Fix initial kvm_has_msr_star
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig0354BED6A3C3B00E99155D8A
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable

Avi Kivity wrote:
> On 12/06/2009 04:51 PM, Jan Kiszka wrote:
>> KVM_GET_MSR_INDEX_LIST returns -E2BIG when the provided space is too
>> small for all MSRs. But this is precisely the error we trigger with th=
e
>> initial request in order to obtain that size. Do not fail in that case=
=2E
>>
>> This caused a subtle corruption of the guest state as MSR_STAR was not=

>> properly saved/restored. The corruption became visible with latest kvm=

>> optimizing the MSR updates.
>>   =20
>=20
> I applied this to qemu-kvm since it missed 0.12-rc1.
>=20

OK, but this part is unused in qemu-kvm as we use our own (unaffected)
implementation there so far.

Jan


--------------enig0354BED6A3C3B00E99155D8A
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iEYEARECAAYFAkscu70ACgkQitSsb3rl5xSetgCg1ehm6ssXAlPFCWYYT69P+9g1
eQEAn0j+K6P6RSbpZBNN2dTnjeM/H1FM
=SVP4
-----END PGP SIGNATURE-----

--------------enig0354BED6A3C3B00E99155D8A--