From: Wei Yongjun <yjwei@cn.fujitsu.com>
To: Keir Fraser <keir.fraser@eu.citrix.com>, xen-devel@lists.xensource.com
Subject: [PATCH] x86: fix to parse multiboot command line passed by latest grub
Date: Mon, 07 Dec 2009 16:26:46 +0800 [thread overview]
Message-ID: <4B1CBC46.6040004@cn.fujitsu.com> (raw)
In-Reply-To: <4B1CBB98.3050408@cn.fujitsu.com>
latest grub had changed to "don't pass filename in multiboot
command line".
The old cmdline format is: "module-name options..."
The new cmdline format is: "options..."
So xen + grub2 always loss the first option, because xen will
skip the first option.
Usually, the module-name is not start with char [a-zA-Z], such
as /boot/vmlinuz, (hd0,1)/boot/vmlinuz, so this patch added
isalpha() test of the first char of modulename/option to
function cmdline_cook(), try to handle both the old and new
cmdline format.
Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -423,6 +423,8 @@
p = p ? : "";
while ( *p == ' ' )
p++;
+ if (isalpha(*p))
+ return p;
while ( (*p != ' ') && (*p != '\0') )
p++;
while ( *p == ' ' )
next prev parent reply other threads:[~2009-12-07 8:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-07 8:23 x86: fix to parse multiboot command line passed by latest grub Wei Yongjun
2009-12-07 8:26 ` Wei Yongjun [this message]
2009-12-07 9:19 ` [PATCH] " Ian Campbell
2009-12-07 9:47 ` Wei Yongjun
2009-12-07 9:48 ` [PATCHv2] " Wei Yongjun
2009-12-07 9:57 ` Keir Fraser
2009-12-07 10:54 ` Samuel Thibault
2009-12-07 22:00 ` Simon Horman
2009-12-07 22:46 ` Samuel Thibault
2009-12-08 7:39 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B1CBC46.6040004@cn.fujitsu.com \
--to=yjwei@cn.fujitsu.com \
--cc=keir.fraser@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.