All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <aliguori@linux.vnet.ibm.com>
To: Avi Kivity <avi@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
	Jan Kiszka <jan.kiszka@web.de>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH] kvm: x86: Fix initial kvm_has_msr_star
Date: Mon, 07 Dec 2009 08:47:13 -0600	[thread overview]
Message-ID: <4B1D1571.7050906@linux.vnet.ibm.com> (raw)
In-Reply-To: <4B1CB903.9000900@redhat.com>

Avi Kivity wrote:
> On 12/06/2009 04:51 PM, Jan Kiszka wrote:
>> KVM_GET_MSR_INDEX_LIST returns -E2BIG when the provided space is too
>> small for all MSRs. But this is precisely the error we trigger with the
>> initial request in order to obtain that size. Do not fail in that case.
>>
>> This caused a subtle corruption of the guest state as MSR_STAR was not
>> properly saved/restored. The corruption became visible with latest kvm
>> optimizing the MSR updates.
>>    
>
> I applied this to qemu-kvm since it missed 0.12-rc1.

I've got it in my tree.  It will be a part of 0.12-rc2 and I'll push to 
master today.

Don't know when 0.11.2 will happen but I'll also push it to the 
stable-0.11 branch.

-- 
Regards,

Anthony Liguori

  parent reply	other threads:[~2009-12-07 14:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-06 14:51 [Qemu-devel] [PATCH] kvm: x86: Fix initial kvm_has_msr_star Jan Kiszka
2009-12-06 14:54 ` [Qemu-devel] [FOR 0.12][FOR 0.11][PATCH] " Jan Kiszka
2009-12-06 15:12 ` [Qemu-devel] [PATCH] " Avi Kivity
2009-12-07  8:12 ` [Qemu-devel] " Avi Kivity
2009-12-07  8:24   ` Jan Kiszka
2009-12-07  8:42     ` Avi Kivity
2009-12-07 14:47   ` Anthony Liguori [this message]
2009-12-07 16:31     ` Avi Kivity
2009-12-07 16:33       ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B1D1571.7050906@linux.vnet.ibm.com \
    --to=aliguori@linux.vnet.ibm.com \
    --cc=avi@redhat.com \
    --cc=jan.kiszka@web.de \
    --cc=mtosatti@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.