From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NHkYC-0005fd-EW for mharc-grub-devel@gnu.org; Mon, 07 Dec 2009 15:51:20 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NHkY9-0005cL-TB for grub-devel@gnu.org; Mon, 07 Dec 2009 15:51:17 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NHkY4-0005Vj-Jf for grub-devel@gnu.org; Mon, 07 Dec 2009 15:51:17 -0500 Received: from [199.232.76.173] (port=56377 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NHkY4-0005VQ-A4 for grub-devel@gnu.org; Mon, 07 Dec 2009 15:51:12 -0500 Received: from mail-yw0-f196.google.com ([209.85.211.196]:65196) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NHkY3-0003ET-Sw for grub-devel@gnu.org; Mon, 07 Dec 2009 15:51:12 -0500 Received: by ywh34 with SMTP id 34so4608431ywh.1 for ; Mon, 07 Dec 2009 12:51:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=Br+w9oO/rHB36ipE1uQOzNL0NPy0tcwQ8hzYa0uyx6E=; b=EDaRCGBjE99X9UzP9Ftwatc7CW27UjY4Kz+UEmpQt2JU5XPha+FL7Kqox1WhyFnlC5 qkFMWnxewbvh5fLN85dHL1OQ66vEpAOcoDt1wAOwG282Zm7AhMAvOgpliyvNzlLNKy6p cNSDkL4YhNTEBqO7r2LpslkrdmNvABmOI0yd4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=jAY1zCh16WXcrr1skNZ0KnzX9RFl3Geu71+1/dk3RryA3b/sH4p5/MgbAGoX9LJqNL eMp0p7bTQDTeU2PPg188b1XyEbdznrutoKTE3A3BeHv8y/rqyRel8LFT1IGlg3/Kxbuh 2SNHOviLt7rQKRd3MTHQ6zT4LcxUTf7GCFeuk= Received: by 10.101.176.2 with SMTP id d2mr5284838anp.27.1260219066627; Mon, 07 Dec 2009 12:51:06 -0800 (PST) Received: from ?192.168.0.75? (cpe-66-69-97-231.satx.res.rr.com [66.69.97.231]) by mx.google.com with ESMTPS id 7sm2140130ywc.36.2009.12.07.12.51.05 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 07 Dec 2009 12:51:05 -0800 (PST) Message-ID: <4B1D6AB9.8070105@gmail.com> Date: Mon, 07 Dec 2009 14:51:05 -0600 From: Bruce Dubbs User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.16) Gecko/20080722 SeaMonkey/1.1.11 MIME-Version: 1.0 To: The development of GNU GRUB References: <4B1D3D7E.5000909@gmail.com> <4B1D5C89.8080104@gmail.com> In-Reply-To: <4B1D5C89.8080104@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: autogen.sh warnings X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Dec 2009 20:51:18 -0000 Vladimir 'φ-coder/phcoder' Serbinenko wrote: > Thanks. I'll let someone more familiar with automake to review automake > parts. Just a comment to import_gcry >> These are generated by util/import_gcry.py by copying (and in some >> cases modifying) the files in lib/libgcrypt to lib/libgcrypt-grub. It >> also creates cipher.h, memory.h, and types.h. >> >> The warnings above appear to be spurious for autogen.sh > crypto and experimental branches have newer import_gcry.py which has > less warning by skipping copying files unnecessary for grub2. If you > want to fix remaining warnings (on rsa, dsa, elgamal, primegen and ecc) > implement assymetric cryptography support (it's planned but may need > changes to core to be useful, there are lower hanging fruits for crypto). I'm not following you completely. I am trying to clean up the build environment, but not getting into the actual code. I think the crypto was just recently merged into trunk, but I'm not knowledgeable about the details yet to make any substantive changes. >> I added code to util/import_gcry.py supress the warnings if a third >> parameter is passed. I then changed autogen.sh to use: >> python util/import_gcry.py lib/libgcrypt/ . NoWarn > This NoWarn is just suppressing legitimate warnings Is a warning that you can't create a subdirectory because it already exists a legitimate warning? The warning about files being copied not being modules seemed to be overkill. Perhaps it could be left in and the WARNING changed to INFO. >> In a release, the lib/libgcrypt-grub/ directory should be released and >> the lib/libgcrypt/ should probably be suppressed to avoid dependence >> on ruby for non-developers. > import_gcry.py is python, not ruby. Yes, I mistyped that. > Generally ./autogen.sh is ran before releasing tarball Yes, but it's also run by someone new (like me) who may want to contribute. The cleaner the better. -- Bruce