Carles Pina i Estany wrote: > And confirmed: if the translator adds %C in the second string > ("Booting a command list") msgfmt -c is not complaining. > > So I would apply your patch, after understanding that it's only for > strings that doesn't have any %C (and in my opinion xgettext could > add the c-format if it's in a C file, but we will not discuss it here > now :-) , I guess that in some cases would not be correct) > > Your patch conflicts with my one (Subject: gettext: grub_printf_ and N_) > but it's not a big problem. If you commit before I would adapt > my one, else I would adapt your one. > > Your N_ patch superseeds Colin's patch. Feel free to use printf_ where necessary. It solves format-security problems -- Regards Vladimir 'φ-coder/phcoder' Serbinenko