From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NHmxA-0001hA-Nq for mharc-grub-devel@gnu.org; Mon, 07 Dec 2009 18:25:16 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NHmx6-0001dg-R4 for grub-devel@gnu.org; Mon, 07 Dec 2009 18:25:12 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NHmx2-0001Xx-Op for grub-devel@gnu.org; Mon, 07 Dec 2009 18:25:12 -0500 Received: from [199.232.76.173] (port=41442 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NHmx2-0001Xh-Gu for grub-devel@gnu.org; Mon, 07 Dec 2009 18:25:08 -0500 Received: from mail-ew0-f215.google.com ([209.85.219.215]:61299) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NHmx1-00039a-0Y for grub-devel@gnu.org; Mon, 07 Dec 2009 18:25:08 -0500 Received: by ewy7 with SMTP id 7so6454588ewy.32 for ; Mon, 07 Dec 2009 15:25:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=pwv0vnvqkQ2mxZIyAyh/CtCAgWe0KF9U5NJjb31e4E4=; b=kdX4aEv36bI0S3akjFNs46i2Mn04cn8lKtjLhx7pxq63IyUJF0Io1dFuFZeZJophq+ /zCcuupsBl61c+IuOALKUVLfgf3QVPD35RJ7p/dWbrDPxEQZY5GyhZfygBBi81KLq69J /obOCo9hOkVKe1wqTa5VSnSz1TJivfNZrMOjw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=dsZuecfb0F6ckPKOwLXMz0Yhf/FKPuOsiIrFdi0n8mRQGNnX+JSDf8mtWnNnVtpsAI yX2dPRV/02Z/V1jqfaph4nLu/9UDpL2kiodmr0UMp1jxcgVNDlqj6KfM4fuNmp/b6olE J6w+0oPG9gRNIgzNg0LTWFQwFJsWUtIQpjBeY= Received: by 10.213.47.5 with SMTP id l5mr262411ebf.12.1260228305939; Mon, 07 Dec 2009 15:25:05 -0800 (PST) Received: from debian.bg45.phnet (gprs01.swisscom-mobile.ch [193.247.250.1]) by mx.google.com with ESMTPS id 13sm3688385ewy.5.2009.12.07.15.25.04 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 07 Dec 2009 15:25:05 -0800 (PST) Message-ID: <4B1D8ECD.9090201@gmail.com> Date: Tue, 08 Dec 2009 00:25:01 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20091109) MIME-Version: 1.0 To: The development of GNU GRUB References: <20091207140923.GA6439@riva.ucam.org> <20091207201408.GA27276@pina.cat> <20091207205420.GI6439@riva.ucam.org> <20091207224630.GA31855@pina.cat> In-Reply-To: <20091207224630.GA31855@pina.cat> X-Enigmail-Version: 0.95.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig029D70495FDD03C6057ACA76" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: Build failures on Ubuntu due to gettext X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Dec 2009 23:25:13 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig029D70495FDD03C6057ACA76 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Carles Pina i Estany wrote: > And confirmed: if the translator adds %C in the second string > ("Booting a command list") msgfmt -c is not complaining. > > So I would apply your patch, after understanding that it's only for > strings that doesn't have any %C (and in my opinion xgettext could > add the c-format if it's in a C file, but we will not discuss it here > now :-) , I guess that in some cases would not be correct) > > Your patch conflicts with my one (Subject: gettext: grub_printf_ and N_= ) > but it's not a big problem. If you commit before I would adapt > my one, else I would adapt your one.=20 > > =20 Your N_ patch superseeds Colin's patch. Feel free to use printf_ where necessary. It solves format-security problems --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig029D70495FDD03C6057ACA76 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iF4EAREKAAYFAksdjs0ACgkQNak7dOguQgnQkwD/R8lX6plapnJ4MCKPvfHlTgh2 ZMATp9KIb2TmHcS9L1kA/1qJTLv1VKNh3YRjhoUcBNyO5Zh/aPQfJuWDUbMh+T5q =9oru -----END PGP SIGNATURE----- --------------enig029D70495FDD03C6057ACA76--