From: Michal Simek <monstr@monstr.eu>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Stop stack clobbering in microblaze-generic.
Date: Tue, 08 Dec 2009 09:28:12 +0100 [thread overview]
Message-ID: <4B1E0E1C.2060308@monstr.eu> (raw)
In-Reply-To: <1260202197-1949-1-git-send-email-graeme.smecher@mail.mcgill.ca>
Hi Graeme,
Graeme Smecher wrote:
> From: Graeme Smecher <gsmecher@tonka.atlantic.home>
>
> A typo caused the stack and malloc regions to overlap, which prevented
> mem_malloc_init() from returning. This commit makes the memory layout match
> the example described in include/configs/microblaze-generic.h
I added your Sign-off-by line and all microblaze patches should have
"microblaze:" prefix in subject. I fixed these things and your patch is
in microblaze repo.
Thanks,
Michal
> ---
> include/configs/microblaze-generic.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/configs/microblaze-generic.h b/include/configs/microblaze-generic.h
> index b486c77..9b1569a 100644
> --- a/include/configs/microblaze-generic.h
> +++ b/include/configs/microblaze-generic.h
> @@ -146,7 +146,7 @@
> #define CONFIG_SYS_MALLOC_BASE (CONFIG_SYS_MONITOR_BASE - CONFIG_SYS_MALLOC_LEN)
>
> /* stack */
> -#define CONFIG_SYS_INIT_SP_OFFSET CONFIG_SYS_MONITOR_BASE
> +#define CONFIG_SYS_INIT_SP_OFFSET CONFIG_SYS_MALLOC_BASE
>
> /*#define RAMENV */
> #define FLASH
--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
next prev parent reply other threads:[~2009-12-08 8:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-07 16:09 [U-Boot] [PATCH] Stop stack clobbering in microblaze-generic Graeme Smecher
2009-12-07 23:13 ` Wolfgang Denk
2009-12-08 8:28 ` Michal Simek [this message]
2009-12-08 16:04 ` Graeme Smecher
2009-12-08 16:09 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B1E0E1C.2060308@monstr.eu \
--to=monstr@monstr.eu \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.