All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Wang <amwang@redhat.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, Jiri Pirko <jpirko@redhat.com>,
	Hugh Dickins <hugh.dickins@tiscali.co.uk>,
	Oleg Nesterov <oleg@redhat.com>,
	akpm@linux-foundation.org, Ingo Molnar <mingo@elte.hu>
Subject: Re: [RFC Patch] getrusage: fill ru_ixrss, ru_idrss and ru_isrss fields
Date: Tue, 08 Dec 2009 17:34:14 +0800	[thread overview]
Message-ID: <4B1E1D96.1020304@redhat.com> (raw)
In-Reply-To: <20091208181117.B5C9.A69D9226@jp.fujitsu.com>

KOSAKI Motohiro wrote:
>> KOSAKI Motohiro wrote:
>>> 	The next three fields, the subject of this patch, are named ru_XXrss:
>>> 	though the 80-column comment omits to say "resident set" before "size",
>>> 	I believe they'd be expected to account (subdivided) resident set sizes?
>>>
>>>
>>> your calculation is not rss nor not integral.
>>>
>> Hmm, I misunderstood rss here. Does it mean the memory stayed in
>> physical mem? i.e. not swapped out.
> 
> Yes.
> 
> Plus, 'integral' mean "tick * rss". but in dyntick environment, per tick statistics is not
> so easy nor low cost.

Thanks for explanation!

> 
>> So, if I want to get those rss statistics, I have to add some more
>> mm_counter by myself? I only find file_rss and anon_rss in mm_struct.
> 
> Hmm..
> I doubt nobody use such statistics. if nobody explain real world usage, I oppose to add
> new counter overhead.

Well, this is one of the usages. :)

I just checked more, I found it's not easy to add rss statistics for
stack, executable, etc... the reason is that we don't have a page flag
to mark a page as used for stack etc.



      reply	other threads:[~2009-12-08  9:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-08  8:30 [RFC Patch] getrusage: fill ru_ixrss, ru_idrss and ru_isrss fields Amerigo Wang
2009-12-08  8:39 ` KOSAKI Motohiro
2009-12-08  8:52   ` Cong Wang
2009-12-08  9:21     ` KOSAKI Motohiro
2009-12-08  9:34       ` Cong Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B1E1D96.1020304@redhat.com \
    --to=amwang@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=hugh.dickins@tiscali.co.uk \
    --cc=jpirko@redhat.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=oleg@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.