Re: [PATCH 2/4] KVM: Add accessor for reading cr4 (or some bits of cr4)

[Avi Kivity <avi@redhat.com>]

On 12/08/2009 09:57 AM, Sheng Yang wrote:
> vcpu->arch.cr0 = cr0;
>> -		vmx_set_cr4(vcpu, vcpu->arch.cr4);
>> +		vmx_set_cr4(vcpu, kvm_read_cr4(vcpu));
>>   	}
>>      
> Another place accessed cr4 directly, in ept_update_paging_mode_cr4()
>
>    

That one is called from vmx_set_cr4(); at that time CR4_READ_SHADOW is 
not up-to-date and vmx_decache_cr4_guest_bits() will actually corrupt 
vcpu->arch.cr4 (except it won't be called, since cr4.pae is never guest 
owned).

But you are right, I should have placed a comment.  I'll add a patch 
that inlines ept_update_paging_mode_cr4 into its caller so it can access 
the cr4 parameter directly instead of vcpu->arch.cr4.

-- 
error compiling committee.c: too many arguments to function