From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/4] KVM: Add accessor for reading cr4 (or some bits of cr4) Date: Tue, 08 Dec 2009 16:44:49 +0200 Message-ID: <4B1E6661.1000604@redhat.com> References: <1260182832-3974-1-git-send-email-avi@redhat.com> <1260182832-3974-3-git-send-email-avi@redhat.com> <200912081557.42822.sheng@linux.intel.com> <4B1E1E3B.3020704@redhat.com> <20091208144014.GA15355@syang10-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Sheng Yang Return-path: Received: from mx1.redhat.com ([209.132.183.28]:50353 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753158AbZLHOoo (ORCPT ); Tue, 8 Dec 2009 09:44:44 -0500 In-Reply-To: <20091208144014.GA15355@syang10-desktop> Sender: kvm-owner@vger.kernel.org List-ID: On 12/08/2009 04:40 PM, Sheng Yang wrote: > >> But you are right, I should have placed a comment. I'll add a patch >> that inlines ept_update_paging_mode_cr4 into its caller so it can >> access the cr4 parameter directly instead of vcpu->arch.cr4. >> > Just notice another thing, seems the cr4_guest_owned_bits' initial value is > wrong. It should be ~KVM_GUEST_CR4_MASK rather than KVM_GUEST_CR4_MASK in this > patch IIUC. > Yes. Will fix. -- error compiling committee.c: too many arguments to function