From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeff Garzik <jeff@garzik.org>
Subject: Re: [PATCH 4/6] cld: modify server code to use logging macros
Date: Tue, 08 Dec 2009 16:28:33 -0500
Message-ID: <4B1EC501.8090508@garzik.org>
References: <1260232984-26726-1-git-send-email-cmccabe@alumni.cmu.edu>	<1260232984-26726-2-git-send-email-cmccabe@alumni.cmu.edu>	<1260232984-26726-3-git-send-email-cmccabe@alumni.cmu.edu>	<1260232984-26726-4-git-send-email-cmccabe@alumni.cmu.edu>	<1260232984-26726-5-git-send-email-cmccabe@alumni.cmu.edu> <20091208111339.5c12115d@redhat.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Return-path: <hail-devel-owner@vger.kernel.org>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:received:received:sender:message-id:date:from
         :user-agent:mime-version:to:cc:subject:references:in-reply-to
         :content-type:content-transfer-encoding;
        bh=t4pUI7Fhagoja7Te+zB+eFRbPXZyR+6/kQvKnxPPny0=;
        b=dJYzSOolBek33mRQaegNeVj3H+OaQQTGNvcF0byyzBsLN9gjaRpNpEgAB30M9lES8n
         Jt3XcD61qbwmy/Ll6CLPDSF5Y3w53rQJI2J9ps8WtBQkZ3qxm10mHkBNGgdGMrsy1m9K
         MnS6VrJ6HrOukVb3lWXB3UzBb485VtX5+wdt0=
In-Reply-To: <20091208111339.5c12115d@redhat.com>
Sender: hail-devel-owner@vger.kernel.org
List-ID: <hail-devel.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"; format="flowed"
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: Colin McCabe <cmccabe@alumni.cmu.edu>, Project Hail List <hail-devel@vger.kernel.org>, Colin McCabe <cmccabe@cobalt.club.cc.cmu.edu>

On 12/08/2009 01:13 PM, Pete Zaitcev wrote:
> On Mon,  7 Dec 2009 16:43:02 -0800
> Colin McCabe<cmccabe@alumni.cmu.edu>  wrote:
>
>> +++ b/server/cld.h
>> @@ -26,6 +26,7 @@
>>   #include<glib.h>
>>   #include "cldb.h"
>>   #include<cld_msg.h>
>> +#include "common.h"
>>   #include<libtimer.h>
>
> This should be<common.h>  since it's common (in include).
>
>> -extern int debugging;
>> +extern struct cld_log srv_log;
>
>> -	applog(LOG_INFO, "databases down");
>> +	CLD_INFO(&srv_log, "databases down");
>
> Great, you took code that was common across Hail and made it specific
> to CLD again.

A fair point...  we did just finish changing from cldlog() to applog()

	Jeff