From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NIIrW-0004W9-2d
	for qemu-devel@nongnu.org; Wed, 09 Dec 2009 04:29:34 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NIIrV-0004Vn-3n
	for qemu-devel@nongnu.org; Wed, 09 Dec 2009 04:29:33 -0500
Received: from [199.232.76.173] (port=43969 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NIIrV-0004Ve-0V
	for qemu-devel@nongnu.org; Wed, 09 Dec 2009 04:29:33 -0500
Received: from bhuna.collabora.co.uk ([93.93.128.226]:58356)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <ian.molton@collabora.co.uk>) id 1NIIrU-0001PM-Li
	for qemu-devel@nongnu.org; Wed, 09 Dec 2009 04:29:32 -0500
Message-ID: <4B1F6DCE.9090603@collabora.co.uk>
Date: Wed, 09 Dec 2009 09:28:46 +0000
From: Ian Molton <ian.molton@collabora.co.uk>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [FOR 0.12 PATCH] qdev: Replace device names
	containing whitespace
References: <m3my1t2o00.fsf@crossbow.pond.sub.org>
In-Reply-To: <m3my1t2o00.fsf@crossbow.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>

Markus Armbruster wrote:

> The place for verbose device names is DeviceInfo member desc.  The
> name should be short & sweet.

Agreed, however...

Why do these (maybe others) get caps in their names? they dont look
right to me, compared to the others with nice names like usb-serial,
piix-ide, or cirrus-vga.

> -    sysbus_register_dev("Uni-north main", sizeof(UNINState),
> +    sysbus_register_dev("Uni-north-main", sizeof(UNINState),
>                          pci_unin_main_init_device);
>      pci_qdev_register(&unin_main_pci_host_info);
> -    sysbus_register_dev("DEC 21154", sizeof(UNINState),
> +    sysbus_register_dev("DEC-21154", sizeof(UNINState),
>                          pci_dec_21154_init_device);
>      pci_qdev_register(&dec_21154_pci_host_info);
> -    sysbus_register_dev("Uni-north AGP", sizeof(UNINState),
> +    sysbus_register_dev("Uni-north-AGP", sizeof(UNINState),
>                          pci_unin_agp_init_device);
>      pci_qdev_register(&unin_agp_pci_host_info);
> -    sysbus_register_dev("Uni-north internal", sizeof(UNINState),
> +    sysbus_register_dev("Uni-north-internal", sizeof(UNINState),
>                          pci_unin_internal_init_device);
>      pci_qdev_register(&unin_internal_pci_host_info);
>  }

-Ian