All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Ronny.Hegewald@online.de
Cc: Dave McCracken <dcm@mccr.org>, xen-devel@lists.xensource.com
Subject: Re: pvops-dom0 console freezes after latest ballooning patch (+possible fix)
Date: Wed, 09 Dec 2009 11:51:38 -0800	[thread overview]
Message-ID: <4B1FFFCA.9060701@goop.org> (raw)
In-Reply-To: <846954254.901022.1260386535441.JavaMail.tomcat55@mrmseu0.kundenserver.de>

On 12/09/09 11:22, Ronny.Hegewald@online.de wrote:
> Setup: xen 3.4.1, 32-bit linux dom0 2.6.31.6 from pvops-git tree from 
> 2009-12-03
>
>
> Since the latest ballooning patch "Add hugepage support to balloon 
> driver 
> <http://git.kernel.org/?p=linux/kernel/git/jeremy/xen.git;a=commit;h=0e898d5e9b893324435e0e77b67fe8d2f0523dbe>" 
> i experience dom0 console freezes. Additional to that there is a 
> stacktrace about a kernel-bug in drivers/xen/balloon.c in line 346, 
> invalide opcode 0000 (i can send the full stacktrace if someone is 
> interested).
>

Yes, please.  Presumably its from the BUG_ON testing the hypercall 
return status?


> The cause for that seems to be that in the 
> decrease_reservation-funtion the PageHighMem - check is not executed 
> on the assocciated page for the current pfn. Its always the last page 
> that got allocated in the for-loop before, when all the pages are 
> allocated.
>
> With the attached patch that crashes dont occur anymore. But im not a 
> kernel-developer so im not sure that this is the correct fix.

It looks reasonable to me.  Dave?

     J

  reply	other threads:[~2009-12-09 19:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-09 19:22 pvops-dom0 console freezes after latest ballooning patch (+possible fix) Ronny.Hegewald
2009-12-09 19:51 ` Jeremy Fitzhardinge [this message]
2009-12-09 20:20   ` Dave McCracken
2009-12-09 20:38     ` Jeremy Fitzhardinge
  -- strict thread matches above, loose matches on Subject: below --
2009-12-09 20:53 Ronny.Hegewald
2009-12-09 20:55 Ronny.Hegewald
2009-12-09 22:18 ` Jeremy Fitzhardinge
2009-12-09 23:28 Ronny.Hegewald

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B1FFFCA.9060701@goop.org \
    --to=jeremy@goop.org \
    --cc=Ronny.Hegewald@online.de \
    --cc=dcm@mccr.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.