From: Jarek Poplawski <jarkao2@gmail.com>
To: Octavian Purdila <opurdila@ixiacom.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
netdev@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Subject: Re: [RFC PATCH] llc: convert the socket list to RCU locking (was Re: [PATCH 3/4] llc: use a device based hash table to speed up multicast delivery)
Date: Wed, 09 Dec 2009 21:52:50 +0100 [thread overview]
Message-ID: <4B200E22.1060306@gmail.com> (raw)
In-Reply-To: <200912082310.45846.opurdila@ixiacom.com>
Octavian Purdila wrote, On 12/08/2009 10:10 PM:
...
> @@ -652,10 +679,10 @@ static int llc_find_offset(int state, int ev_type)
> void llc_sap_add_socket(struct llc_sap *sap, struct sock *sk)
> {
> llc_sap_hold(sap);
> - write_lock_bh(&sap->sk_list.lock);
> + spin_lock_bh(&sap->sk_lock);
> llc_sk(sk)->sap = sap;
> - sk_add_node(sk, &sap->sk_list.list);
> - write_unlock_bh(&sap->sk_list.lock);
> + sk_nulls_add_node_rcu(sk, &sap->sk_list);
> + spin_lock_bh(&sap->sk_lock);
------->^^^^^^^^^^
Jarek P.
next prev parent reply other threads:[~2009-12-09 20:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-03 22:31 [PATCH 0/4] llc enhancements Octavian Purdila
2009-12-03 22:31 ` [PATCH 1/4] llc: use dev_hard_header Octavian Purdila
2009-12-03 22:31 ` [PATCH 2/4] llc: add support for LLC_OPT_PKTINFO Octavian Purdila
2009-12-03 22:31 ` [PATCH 3/4] llc: use a device based hash table to speed up multicast delivery Octavian Purdila
2009-12-03 22:59 ` Eric Dumazet
2009-12-03 23:30 ` Octavian Purdila
2009-12-03 23:52 ` Eric Dumazet
2009-12-04 0:15 ` Octavian Purdila
2009-12-04 0:28 ` Eric Dumazet
2009-12-08 21:10 ` [RFC PATCH] llc: convert the socket list to RCU locking (was Re: [PATCH 3/4] llc: use a device based hash table to speed up multicast delivery) Octavian Purdila
2009-12-08 21:26 ` Eric Dumazet
2009-12-09 20:19 ` Eric Dumazet
2009-12-09 20:36 ` Octavian Purdila
2009-12-09 21:49 ` Octavian Purdila
2009-12-09 22:34 ` Eric Dumazet
2009-12-09 20:52 ` Jarek Poplawski [this message]
2009-12-03 23:25 ` [PATCH 3/4] llc: use a device based hash table to speed up multicast delivery Stephen Hemminger
2009-12-03 23:53 ` Octavian Purdila
2009-12-04 0:37 ` Stephen Hemminger
2009-12-03 22:31 ` [PATCH 4/4] llc: replace the socket list with a local address based hash Octavian Purdila
2009-12-03 23:55 ` [PATCH 0/4] llc enhancements David Miller
2009-12-04 0:20 ` Octavian Purdila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B200E22.1060306@gmail.com \
--to=jarkao2@gmail.com \
--cc=acme@ghostprotocols.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=opurdila@ixiacom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.