Re: [RFC] gianfar: Fix stats support

[Eric Dumazet <eric.dumazet@gmail.com>]

Le 10/12/2009 08:43, Kumar Gopalpet-B05799 a écrit :
>  
>> Fine by me, but if this patch is for linux-2.6.33, you can use 
>> dev_txq_stats_fold() helper in your gfar_get_stats()
>>
>> dev_txq_stats_fold(dev, &dev->stats);
>> return &dev->stats;
>>
> 
> Eric, the problem in using dev_txq_stats_fold() will be that
> txq->tx_dropped will not be updated. tx_dropped counter is updated on a
> device level in the gfar_error( ) interrupt context (here we do not know
> the txq index).
> So, if we use dev_txq_stats_fold(), we will incorrectly give the
> tx_dropped stats.

Ah yes, you are very right, thanks !