From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andres Lagar-Cavilla <andres@lagarcavilla.com>
Subject: Re: [PATCH] libxenlight: implement
	libxl_set_memory_target
Date: Thu, 10 Dec 2009 09:01:32 -0500
Message-ID: <4B20FF3C.8090501@lagarcavilla.com>
References: <20091208200031.4903B5980EB@homiemail-mx11.g.dreamhost.com>
	<4B1EB743.3090102@lagarcavilla.com>
	<alpine.DEB.2.00.0912091249190.9654@kaball-desktop>
	<4B200CD5.30807@lagarcavilla.com>
	<alpine.DEB.2.00.0912101337020.27698@kaball-desktop>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <alpine.DEB.2.00.0912101337020.27698@kaball-desktop>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Vincent Hanquez <Vincent.Hanquez@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

Errrr, no.
http://xenbits.xen.org/xen-unstable.hg?file/8f304c003af4/tools/libxl/libxl.c 
shows that the videoram node will be set only if we are using a 
device-model. And specifically if we are in fully virtualized mode, i.e. 
dm_info->type == XENFV, i.e. *not* PV
Andres
Stefano Stabellini wrote:
> On Wed, 9 Dec 2009, Andres Lagar-Cavilla wrote:
>   
>> Stefano Stabellini wrote:
>>     
>>> On Tue, 8 Dec 2009, Andres Lagar-Cavilla wrote:
>>>   
>>>       
>>>> Hi,
>>>> couple of comments:
>>>> - PV domains without videoram won't be able to use this
>>>>     
>>>>         
>>> PV domains just have videoram = 0.
>>>   
>>>       
>> But you abort libxl_set_memory_target if the videoram node is not found. 
>> Which won't be for PVs with no videoram...
>> +    videoram_s = libxl_xs_read(ctx, XBT_NULL, libxl_sprintf(ctx, 
>> "%s/memory/videoram", dompath));
>> +    if (!videoram_s)
>> +        return -1;
>>
>>     
>
> The videoram node will be found, and the value will be 0.
>
>