Re: [PATCH] libxenlight: implement libxl_set_memory_target

[Andres Lagar-Cavilla <andres@lagarcavilla.com>]

Oh, I'm working with an old changeset. Yikes. Thanks,
Andres
Stefano Stabellini wrote:
> On Thu, 10 Dec 2009, Andres Lagar-Cavilla wrote:
>   
>> Errrr, no.
>> http://xenbits.xen.org/xen-unstable.hg?file/8f304c003af4/tools/libxl/libxl.c 
>> shows that the videoram node will be set only if we are using a 
>> device-model. And specifically if we are in fully virtualized mode, i.e. 
>> dm_info->type == XENFV, i.e. *not* PV
>>     
>
> I understand that this can be confusing, but at the moment we have two
> videoram parameters: dm_info->videoram is for the device model while
> b_info->video_memkb is for domain building.
> If you look at init_dm_info, you'll see that dm_info->videoram is set
> from b_info->video_memkb.
> Also if you read libxl_dom.c:build_post you'll see that no matter if the
> guest is a pv or an hvm domain, memory/videoram will be written to
> xenstore anyway.
>
>