From: Anthony Liguori <aliguori@linux.vnet.ibm.com>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 10/19] monitor: Convert do_info_name() to QObject
Date: Thu, 10 Dec 2009 10:20:47 -0600 [thread overview]
Message-ID: <4B211FDF.4070509@linux.vnet.ibm.com> (raw)
In-Reply-To: <4B211D6F.7020906@redhat.com>
Avi Kivity wrote:
> But we have two null conditions to check for, in an extendible
> dictionary:
>
> 1. The feature is unknown to qemu
> 2. The feature is known to qemu, but disabled
>
> So, "if 'field' in result:" tests the former, and "if
> result['field']:" tests the latter.
>
> In your example, a period of None makes no sense, so it would be
> sufficient to
>
> period = hpet_info.get('period', 0.100)
By the same token, wouldn't you probably do:
name = hpet_info.get('name', None)
Let me put it another way, I don't think adding null to the json parser
and incorporating it into this command is a good idea at this stage in
the release so if we want to do something like this, we need to defer it
to 0.13.
I agree there are some instances where null could be useful. I think we
can get away without it here though.
--
Regards,
Anthony Liguori
next prev parent reply other threads:[~2009-12-10 16:21 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-09 16:27 [Qemu-devel] [FOR 0.12 v3 00/19]: info handlers conversions to QObject Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 01/19] Introduce qemu-objects.h header file Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 02/19] Makefile: move QObject objs to their own entry Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 03/19] QDict: Introduce qdict_get_qbool() Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 04/19] QDict: Introduce qdict_get_qlist() Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 05/19] monitor: Fix do_info_balloon() output Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 06/19] monitor: do_info_cpus(): Use QBool Luiz Capitulino
2009-12-10 10:44 ` Markus Armbruster
2009-12-10 12:00 ` Luiz Capitulino
2009-12-10 13:01 ` Anthony Liguori
2009-12-10 13:05 ` Luiz Capitulino
2009-12-10 13:08 ` Anthony Liguori
2009-12-10 13:10 ` Anthony Liguori
2009-12-10 13:22 ` Markus Armbruster
2009-12-09 16:27 ` [Qemu-devel] [PATCH 07/19] monitor: do_info_version(): Use QDict Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 08/19] monitor: Convert do_info_status() to QObject Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 09/19] monitor: Convert do_info_kvm() " Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 10/19] monitor: Convert do_info_name() " Luiz Capitulino
2009-12-10 10:09 ` Markus Armbruster
2009-12-10 11:52 ` Luiz Capitulino
2009-12-10 12:56 ` Anthony Liguori
2009-12-10 15:55 ` Avi Kivity
2009-12-10 15:57 ` Avi Kivity
2009-12-10 16:03 ` Anthony Liguori
2009-12-10 16:10 ` Avi Kivity
2009-12-10 16:20 ` Anthony Liguori [this message]
2009-12-10 16:24 ` Avi Kivity
2009-12-10 16:54 ` Luiz Capitulino
2009-12-10 17:02 ` Avi Kivity
2009-12-10 17:12 ` Luiz Capitulino
2009-12-10 17:38 ` Daniel P. Berrange
2009-12-10 17:49 ` Luiz Capitulino
2009-12-10 18:00 ` Daniel P. Berrange
2009-12-11 12:54 ` Luiz Capitulino
2009-12-11 13:14 ` Anthony Liguori
2009-12-11 13:20 ` Anthony Liguori
2009-12-11 19:46 ` Daniel P. Berrange
2009-12-11 13:18 ` Anthony Liguori
2009-12-11 13:27 ` Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 11/19] monitor: Convert do_info_hpet() " Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 12/19] monitor: Convert do_info_uuid() " Luiz Capitulino
2009-12-10 10:14 ` Markus Armbruster
2009-12-09 16:27 ` [Qemu-devel] [PATCH 13/19] monitor: Convert do_info_mice() " Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 14/19] migration: Convert do_info_migrate() " Luiz Capitulino
2009-12-10 10:19 ` Markus Armbruster
2009-12-09 16:27 ` [Qemu-devel] [PATCH 15/19] block: Convert bdrv_info() " Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 16/19] block: Convert bdrv_info_stats() " Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 17/19] char: Convert qemu_chr_info() " Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 18/19] PCI: Convert pci_device_hot_add() " Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 19/19] VNC: Convert do_info_vnc() " Luiz Capitulino
2009-12-10 10:34 ` Markus Armbruster
2009-12-10 11:56 ` Luiz Capitulino
2009-12-10 12:12 ` Daniel P. Berrange
2009-12-10 13:00 ` Anthony Liguori
2009-12-10 10:49 ` [Qemu-devel] [FOR 0.12 v3 00/19]: info handlers conversions " Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B211FDF.4070509@linux.vnet.ibm.com \
--to=aliguori@linux.vnet.ibm.com \
--cc=armbru@redhat.com \
--cc=avi@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.