From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] at_hdmac.c: use resource_size()
Date: Fri, 11 Dec 2009 10:02:59 +0100 [thread overview]
Message-ID: <4B220AC3.3080405@atmel.com> (raw)
In-Reply-To: <BD79186B4FD85F4B8E60E381CAEE190901FB0FC1@mi8nycmail19.Mi8.com>
H Hartley Sweeten :
> Use resource_size() for ioremap.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
>
> diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
> index c52ac9e..e16057b 100644
> --- a/drivers/dma/at_hdmac.c
> +++ b/drivers/dma/at_hdmac.c
> @@ -1012,7 +1012,7 @@ static int __init at_dma_probe(struct platform_device *pdev)
> atdma->dma_common.cap_mask = pdata->cap_mask;
> atdma->all_chan_mask = (1 << pdata->nr_channels) - 1;
>
> - size = io->end - io->start + 1;
> + size = resource_size(io);
> if (!request_mem_region(io->start, size, pdev->dev.driver->name)) {
> err = -EBUSY;
> goto err_kfree;
>
--
Nicolas Ferre
prev parent reply other threads:[~2009-12-11 9:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-11 1:29 [PATCH] at_hdmac.c: use resource_size() H Hartley Sweeten
2009-12-11 9:02 ` Nicolas Ferre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B220AC3.3080405@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=hartleys@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.