All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wenji Huang <wenji.huang@oracle.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Return value of print_graph_prologue
Date: Fri, 11 Dec 2009 18:12:31 +0800	[thread overview]
Message-ID: <4B221B0F.6040107@oracle.com> (raw)

Hi,

I got confused about the return value of print_graph_prologue. See:

805         /* Latency format */
806         if (trace_flags & TRACE_ITER_LATENCY_FMT) {
807                 ret = print_graph_lat_fmt(s, ent);
808                 if (ret == TRACE_TYPE_PARTIAL_LINE)
809                         return TRACE_TYPE_PARTIAL_LINE;
810         }
811
812         return 0;
813 }

But we have defined TRACE_TYPE_PARTIAL_LINE = 0. So there's
no difference between success and failure?

Should it be TRACE_TYPE_HANDLED ?

Regards,
Wenji

             reply	other threads:[~2009-12-11 10:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-11 10:12 Wenji Huang [this message]
2009-12-11 11:04 ` Return value of print_graph_prologue Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B221B0F.6040107@oracle.com \
    --to=wenji.huang@oracle.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.