From: Jes Sorensen <jes.sorensen@gmail.com>
To: Alan Jenkins <sourcejedi.lkml@googlemail.com>
Cc: linux-acpi@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
lenb@kernel.org, Matthew Garrett <mjg59@srcf.ucam.org>
Subject: Re: PATCH: Toshiba Bluetooth enabler (v3)
Date: Fri, 11 Dec 2009 11:51:18 +0100 [thread overview]
Message-ID: <4B222426.8000904@gmail.com> (raw)
In-Reply-To: <9b2b86520912100900p5796bc35q702af615d3f27a0c@mail.gmail.com>
On 12/10/09 18:00, Alan Jenkins wrote:
> I did question "depends on RFKILL". If you manually configure a
> kernel, you will miss "If you have a modern Toshiba laptop with a
> Bluetooth and an RFKill switch (such as the Portege R500), say Y."
> unless you enable RFKILL first. (Which is unnecessary since the
> driver will work exactly the same with RFKILL=n). I wouldn't call it
> a strong objection, but it would be nice to hear the reason you
> included this dependency.
>
> Everything else looks fine. Thanks for working on this.
> Alan
The driver is acting as RFKill functionality, even if it doesn't
provide it in full. We can pull that depend if you like, however
I still think it's awkward to offer a driver for a functionality
the user had previously said no to.
Cheers,
Jes
next prev parent reply other threads:[~2009-12-11 10:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-04 15:38 [PATCH] Toshiba Bluetooth enabler (rfkill) Jes Sorensen
2009-12-08 10:05 ` Alan Jenkins
2009-12-08 12:55 ` Matthew Garrett
2009-12-08 15:45 ` Jes Sorensen
2009-12-08 15:47 ` Matthew Garrett
2009-12-08 15:50 ` Jes Sorensen
2009-12-08 15:51 ` Matthew Garrett
2009-12-08 21:30 ` Alan Jenkins
2009-12-08 16:58 ` Toshiba Bluetooth enabler (v2) (was: Re: [PATCH] Toshiba Bluetooth enabler (rfkill)) Jes Sorensen
2009-12-09 13:17 ` Alan Jenkins
2009-12-09 13:17 ` Alan Jenkins
2009-12-10 13:27 ` Dan Carpenter
2009-12-10 13:47 ` Alan Jenkins
2009-12-10 13:47 ` Alan Jenkins
2009-12-10 15:27 ` PATCH: Toshiba Bluetooth enabler (v3) Jes Sorensen
2009-12-10 17:00 ` Alan Jenkins
2009-12-11 10:51 ` Jes Sorensen [this message]
2009-12-11 13:08 ` Alan Jenkins
2009-12-16 17:06 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B222426.8000904@gmail.com \
--to=jes.sorensen@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=sourcejedi.lkml@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.