From: Milan Broz <mbroz@redhat.com>
To: "Nico R." <n-roeser@gmx.net>
Cc: dm-crypt@saout.de
Subject: Re: [dm-crypt] Exhaustive key reading seems to silently stop on error
Date: Fri, 11 Dec 2009 12:59:07 +0100 [thread overview]
Message-ID: <4B22340B.8060500@redhat.com> (raw)
In-Reply-To: <4B22258A.4070009@gmx.net>
On 12/11/2009 11:57 AM, Nico R. wrote:
>>> In lib/utils.c (line 450f. in cryptsetup-1.0.7; line 490f. in current
>>> SVN revision, r132, equal to r152), we see the following code:
>>>
>>> if(read(fd, pass + i, 1) != 1 || (newline_stop && pass[i] == '\n'))
>>> break;
>>>
>>> If I interpret that snipped (and its surroundings) correctly, the code
>>> will read until EOF *or* until an error occurs.
yes, sure it is bug, thanks for reporting it.
Fixed in trunk now
http://code.google.com/p/cryptsetup/source/detail?r=154#
Milan
--
mbroz@redhat.com
prev parent reply other threads:[~2009-12-11 11:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-09 22:25 [dm-crypt] Exhaustive key reading seems to silently stop on error Nico R.
2009-12-11 4:06 ` Arno Wagner
2009-12-11 10:57 ` Nico R.
2009-12-11 11:59 ` Milan Broz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B22340B.8060500@redhat.com \
--to=mbroz@redhat.com \
--cc=dm-crypt@saout.de \
--cc=n-roeser@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.