From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gary Grebus <Gary.Grebus@oracle.com>
Subject: Re: losetup -f not working on SLES10
Date: Fri, 11 Dec 2009 10:03:55 -0500
Message-ID: <4B225F5B.6070502@oracle.com>
References: <C747CF8F.423C%keir.fraser@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <C747CF8F.423C%keir.fraser@eu.citrix.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: Andre Przywara <andre.przywara@amd.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

Keir Fraser wrote:
> Fine by me.
> 
>  K.
> 
> On 11/12/2009 10:03, "Andre Przywara" <andre.przywara@amd.com> wrote:
> 
>> Hi,
>>
>> c/s 20404 (http://xenbits.xen.org/xen-unstable.hg?rev/830bda7a9c75)
>> introduces "losetup -f" to the hotplug scripts to find a free loop
>> device. This option does not exists on SLES10, so Xen unstable does not
>> work any longer on top on SLES10. I see that using -f is much smarter
>> than the old-fashioned way, but shouldn't we keep compatibility with
>> older Dom0 userlands?

Ooops. I thought I checked that SLES10 had "-f", but apparently it was
openSUSE.

>> Is a patch providing fallback to the old code an option?

Or maybe cleaner to just scan the output of "losetup -a" for
the first unassigned device?  I can work up a patch.

	/gary