All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Dickson <SteveD@redhat.com>
To: Kelly Anderson <kelly-lACMDn57031vQQPgy9v2K1aTQe2KTcn/@public.gmane.org>
Cc: nfs@lists.sourceforge.net
Subject: Re: [NFS] Nfs4 over Ipv6 patch to fix ipv6 subnetting in /etc/exports
Date: Fri, 11 Dec 2009 13:19:55 -0500	[thread overview]
Message-ID: <4B228D4B.7000007@RedHat.com> (raw)
In-Reply-To: <4B16EF49.8040106-lACMDn57031vQQPgy9v2K1aTQe2KTcn/@public.gmane.org>

Hello,

On 12/02/2009 05:50 PM, Kelly Anderson wrote:
> --- ./support/export/client.c.orig	2009-11-30 08:06:18.000000000 -0700
> +++ ./support/export/client.c	2009-12-02 15:16:55.361725808 -0700
> @@ -505,16 +505,16 @@ check_subnet_v6(const struct sockaddr_in
>  			continue;
>  
>  		if (mask_match(address->sin6_addr.s6_addr32[0],
> -				sin6->sin6_addr.s6_addr[0],
> +				sin6->sin6_addr.s6_addr32[0],
>  		      		mask->sin6_addr.s6_addr32[0]) &&
>  		    mask_match(address->sin6_addr.s6_addr32[1],
> -				sin6->sin6_addr.s6_addr[1],
> +				sin6->sin6_addr.s6_addr32[1],
>  		      		mask->sin6_addr.s6_addr32[1]) &&
>  		    mask_match(address->sin6_addr.s6_addr32[2],
> -				sin6->sin6_addr.s6_addr[2],
> +				sin6->sin6_addr.s6_addr32[2],
>  		      		mask->sin6_addr.s6_addr32[2]) &&
>  		    mask_match(address->sin6_addr.s6_addr32[3],
> -				sin6->sin6_addr.s6_addr[3],
> +				sin6->sin6_addr.s6_addr32[3],
>  		      		mask->sin6_addr.s6_addr32[3]))
>  			return 1;
>  	}
I'm a bit confused here... I don't see a check_subnet_v6() routine
in support/export/client.c and from the git logs says there never
was a routine called check_subnet_v6()... what am I missing?

In the future, please add the Signed-off-by: label to the bottom
of the patch description... thanks!


steved.

------------------------------------------------------------------------------
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
_______________________________________________
Please note that nfs@lists.sourceforge.net is being discontinued.
Please subscribe to linux-nfs@vger.kernel.org instead.
    http://vger.kernel.org/vger-lists.html#linux-nfs


  parent reply	other threads:[~2009-12-11 18:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-02 22:50 [NFS] Nfs4 over Ipv6 patch to fix ipv6 subnetting in /etc/exports Kelly Anderson
     [not found] ` <4B16EF49.8040106-lACMDn57031vQQPgy9v2K1aTQe2KTcn/@public.gmane.org>
2009-12-02 23:32   ` Chuck Lever
2009-12-03  0:16     ` Kelly Anderson
     [not found]       ` <4B170344.9070205-lACMDn57031vQQPgy9v2K1aTQe2KTcn/@public.gmane.org>
2009-12-03  0:25         ` Chuck Lever
2009-12-11 18:19   ` Steve Dickson [this message]
     [not found]     ` <4B228D4B.7000007-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2009-12-11 18:24       ` Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B228D4B.7000007@RedHat.com \
    --to=steved@redhat.com \
    --cc=kelly-lACMDn57031vQQPgy9v2K1aTQe2KTcn/@public.gmane.org \
    --cc=nfs@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.