All of lore.kernel.org
 help / color / mirror / Atom feed
From: Surbhi Palande <surbhi.palande@canonical.com>
To: Frank Mayhar <fmayhar@google.com>
Cc: Eric Sandeen <sandeen@redhat.com>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] replaced BUG() with return -EIO	from	ext4_ext_get_blocks
Date: Sat, 12 Dec 2009 00:11:31 +0200	[thread overview]
Message-ID: <4B22C393.2090709@canonical.com> (raw)
In-Reply-To: <1260562923.21896.11.camel@bobble.smo.corp.google.com>

Hi Frank,

Frank Mayhar wrote:
> On Fri, 2009-12-11 at 14:02 -0600, Eric Sandeen wrote:
>   
>> My first thought was that this was a bandaid too, but I guess it can
>> come about due to on-disk corruption for any reason, so it should
>> be handled gracefully, and I suppose this approach seems fine.
>>     
>
> That's why we've been running with it, yes.
>
>   
>> Since this is catching on-disk corruption, though, it'd be better to call
>> ext4_error() and let the mount-time error-handling policy decide what to do.
>>
>> I like having more info but below seems awfully wordy ;)  Maybe the first
>> printk would suffice, and switching it to an ext4_error() would be best,
>> I think.
>>     
>
> Okay, I'll rework the patch a bit and resubmit it.
>   
Since I published this patch first against a reported upstream bug, I
will work on the comments and resubmit the patch!

Thanks for your comments !

Warm Regards,
Surbhi.

  parent reply	other threads:[~2009-12-11 22:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-11 14:06 [PATCH] replaced BUG() with return -EIO from ext4_ext_get_blocks Surbhi Palande
2009-12-11 18:07 ` Frank Mayhar
2009-12-11 20:02   ` Eric Sandeen
2009-12-11 20:22     ` Frank Mayhar
2009-12-11 20:31       ` Eric Sandeen
2009-12-11 21:11         ` Frank Mayhar
2009-12-11 22:11       ` Surbhi Palande [this message]
2009-12-11 22:16         ` Frank Mayhar
2009-12-12 21:00     ` [PATCH v2] " Surbhi Palande
2009-12-14 15:04       ` tytso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B22C393.2090709@canonical.com \
    --to=surbhi.palande@canonical.com \
    --cc=fmayhar@google.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.