Re: [Adeos-main] [pull request] x86: critical fix for native_safe_halt

[Jan Kiszka <jan.kiszka@domain.hid>]

[-- Attachment #1: Type: text/plain, Size: 1025 bytes --]

Philippe Gerum wrote:
> On Sat, 2009-12-12 at 22:37 +0100, Jan Kiszka wrote:
>> Recent moving of ipipe_suspend_domain finally exposed a deeper flaw in
>> cpu_idle on x86: We failed to check the pipeline log before issuing the
>> real hlt. This caused IRQ latencies or even drops for Linux,
>> specifically on SMP. Credits go to plain QEMU whose slow SMP mode caused
>> ipipe_critical_enter to deadlock frequently enough.
>>
>> The first patch of this series fixes this (see below), the second one
>> simply removes the two useless ipipe_suspend_domain calls.
>>
> 
> What your patch does as well, is killing the ability to run low priority
> domains below the root level.

Yes, I'm killing the dream.

I heavily doubt that the functions I removed in the second patch ever
contributed something good to this. It's always the job of the lowest
domain to issue hardware halt, not of some arbitrary mid-prio domain.
Moreover, what would be the practical use for such model in the context
of Linux?

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]