Re: [PATCH] orinoco: fix GFP_KERNEL in orinoco_set_key with interrupts disabled

[Dave <kilroyd@googlemail.com>]

Andrey Borzenkov wrote:
> On Thursday 10 of December 2009 21:34:53 Dave wrote:
>> Andrey Borzenkov wrote:
>>> I had to resurrect old notebook and immediately hit this under
>>> 2.6.32:
>>>
>>> [   77.254109] WARNING: at
>>> /home/bor/src/linux-git/kernel/lockdep.c:2465 lockdep
>>> _trace_alloc+0x9a/0xa0()
>>>
>>> Until orinoco_lock can be converted from spinlock into mutex, this
>>> patch is the most simple solution.
>> Thank you Andrey. The patch is correct (though it could clean up the
>> misdirected comment 4 or 5 lines above).
> 
> Do you want me to resubmit with this cleanup?
> 
>> Is it worth pushing this to stable?
> 
> I think yes. Sleeping under spinlock with interrupts disabled is not fun 
> even if it is very unlikely.

If I understand it right, we want to cc the patch to stable@kernel.org.
So if you could take care of that comment and resubmit with cc (and
something in the title so John can tell we'd like this in 2.6.33 as
well), everyone's happy

<festive>
and Santa distributes the patch to all the good little kernels and
kernelettes
</festive>


Dave.