From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: john.dykstra1@gmail.com, lists@nerdbynature.de,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: Badness at net/ipv4/inet_connection_sock.c:293
Date: Mon, 14 Dec 2009 20:22:13 +0100 [thread overview]
Message-ID: <4B269065.5000601@gmail.com> (raw)
In-Reply-To: <20091214.111105.224947761.davem@davemloft.net>
Le 14/12/2009 20:11, David Miller a écrit :
> From: John Dykstra <john.dykstra1@gmail.com>
> Date: Mon, 14 Dec 2009 18:57:13 +0000
>
>> That test was changed to match a change in the return values of
>> tcp_ack(). No logic change was intended.
>
> As Eric pointed out, changing tcp_ack()'s behavior effects state
> transitions out of SYN_ACK, so this commit is very likely the culprit.
>
> I usually see 2 or 3 three of these bug triggers in the first ten
> minutes after bootup and I haven't seen one yet in 20 minutes
> with the commit reverted.
>
> This change is definitely wrong.
Hmm, I didnt yet spotted the problem, just gave some hints ...
next prev parent reply other threads:[~2009-12-14 19:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-12 7:43 Badness at net/ipv4/inet_connection_sock.c:293 Christian Kujau
2009-12-12 9:03 ` David Miller
2009-12-12 9:22 ` Eric Dumazet
2009-12-12 10:06 ` lists
2009-12-14 5:56 ` Eric Dumazet
2009-12-14 7:45 ` David Miller
2009-12-14 17:34 ` Eric Dumazet
2009-12-14 18:19 ` David Miller
2009-12-14 18:57 ` John Dykstra
2009-12-14 19:11 ` David Miller
2009-12-14 19:16 ` David Miller
2009-12-14 19:23 ` Eric Dumazet
2009-12-14 19:26 ` David Miller
2009-12-14 22:35 ` David Miller
2009-12-15 7:18 ` David Miller
2009-12-15 8:45 ` Eric Dumazet
2009-12-16 4:50 ` David Miller
2009-12-16 4:57 ` David Miller
2009-12-14 19:22 ` Eric Dumazet [this message]
2009-12-14 19:24 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B269065.5000601@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=john.dykstra1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lists@nerdbynature.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.