From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH 0/6 v2] logging refactoring Date: Mon, 14 Dec 2009 15:36:16 -0500 Message-ID: <4B26A1C0.2080401@garzik.org> References: <1260317516-30991-1-git-send-email-cmccabe@alumni.cmu.edu> <436f52800912132323paf46ea2j6392ce81e13a7981@mail.gmail.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=mxN3YMTY1B8Va1q6PW/uE7ZIDkn38JvZBScJtLAi7Mk=; b=JnXw5Wj0J7Wc9svI+VMj+hQWWKv6bQoTfkp3eaPgtBuI+4lB2WgnTB+47jKPKqyvLJ g4zMpxYXnT5+D3FIp2MwHf2oVfDlW3tGvg7foTbyCSjSJzd0Ac75Jzk5JgOrnQkQt9TZ fOCyZGwtI+yy9xdapard1DFklmPIAwI1Cnhec= In-Reply-To: <436f52800912132323paf46ea2j6392ce81e13a7981@mail.gmail.com> Sender: hail-devel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Colin McCabe Cc: Project Hail List , Pete Zaitcev On 12/14/2009 02:23 AM, Colin McCabe wrote: > Hi all, > > I think I'm going to respin this patch to be a lot smaller. Just > refactor one or two things, but leave the existing "verbose" and > "applog" system in place. Let me know what you think-- do you think I > should push ahead with HAIL_DEBUG etc., Well... I was waiting until today to see if downstream API-related patches would appear. Prior to CLD version 1.0, the "rules" are that any and all network protocol or client API changes are OK. After 1.0, we will need to take typical userland library precautions to properly version API changes, avoid breakage, etc. However, even prior to v1.0, API changes do introduce breakage in chunkd and tabled. Typically, if you make a client API change, patches to update the other projects should be provided as well. So I was leaning towards applying and then fixing up chunkd/tabled myself, but any proposed alternative described as "just refactor a thing or two" is certainly very appealing :) It's up to you... Jeff